Fix/plugins list status text delete counts - #11777
Conversation
…uginSuccess. Decrement counts for groups registered via the plugins_list filter when a plugin is deleted via AJAX, so tabs whose label is supplied through plugins_list_status_text (introduced in #60495) stay in sync without a page reload. See #65191.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @andreas-am. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi @alessioarzenton! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Pull request overview
This PR refactors how list-table “view” links (the .subsubsub navigation) render their | separators by moving the separator from PHP output into CSS, and updates the plugin-deletion UI logic so custom plugin groups (added via plugins_list / labeled via plugins_list_status_text) have their counts kept in sync after an AJAX delete.
Changes:
- Adjusts
WP_List_Table::views()output to stop hardcoding the|separator between<li>items. - Adds a CSS
::afterseparator for.subsubsublist items. - Extends
wp.updates.deletePluginSuccess()to decrement/remove counts for custom plugin groups in the filter navigation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/wp-admin/includes/class-wp-list-table.php |
Removes hardcoded ` |
src/wp-admin/css/common.css |
Adds CSS-based separator styling for .subsubsub list items. |
src/js/_enqueues/wp/updates.js |
Decrements/removes custom plugin-group view counts after AJAX plugin deletion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .subsubsub li:not(:last-child)::after { | ||
| content: "|"; | ||
| } |
| echo "<ul class='subsubsub'>\n"; | ||
| foreach ( $views as $class => $view ) { | ||
| $views[ $class ] = "\t<li class='$class'>$view"; | ||
| } | ||
| echo implode( " |</li>\n", $views ) . "</li>\n"; | ||
| echo implode( " </li>\n", $views ) . "</li>\n"; |
| if ( plugins[ key ].length ) { | ||
| $views.find( '.' + key + ' .count' ).text( '(' + plugins[ key ].length + ')' ); | ||
| } else { | ||
| $views.find( '.' + key ).remove(); | ||
| } |
| // Decrement counts for any custom group added through the | ||
| // `plugins_list` filter (e.g. a tab whose label is supplied | ||
| // via `plugins_list_status_text`, introduced in #60495). | ||
| _.each( _.keys( plugins ), function( key ) { | ||
| if ( -1 !== _.indexOf( knownKeys, key ) ) { |
Improvement to PR: #11752.
This PR refactors the rendering of the | separator between filter links in WP_List_Table::views() (the .subsubsub navigation — e.g. "All | Active | Inactive" on the Plugins screen).
Before: the separator was hardcoded in the PHP output via implode( " |\n", $views ) in wp-admin/includes/class-wp-list-table.php.
After: PHP emits clean markup, and the separator is drawn in CSS via a ::after pseudo-element.
Trac ticket: https://core.trac.wordpress.org/ticket/65191
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.