Conversation
When similar functions differ only in the targets of their respective Call expressions, MergeSimilarFunctions can merge the functions and pass the correct call target in as a function reference. If the call targets were not previously referenced, they might previously have had private types. In an open world where `func` is exposed on the boundary, this transformation will make the private types public. Since public types can have stricter validation rules than private types (e.g. public types may not contain exact references when custom descriptors are disallowed), this could previously create invalid public types. Fix the bug by adding a check that the call target has a valid public type before doing the optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When similar functions differ only in the targets of their respective Call expressions, MergeSimilarFunctions can merge the functions and pass the correct call target in as a function reference. If the call targets were not previously referenced, they might previously have had private types. In an open world where
funcis exposed on the boundary, this transformation will make the private types public. Since public types can have stricter validation rules than private types (e.g. public types may not contain exact references when custom descriptors are disallowed), this could previously create invalid public types. Fix the bug by adding a check that the call target has a valid public type before doing the optimization.