[NFC] Remove ancient trapping-mode support code - #9095
Merged
Conversation
Member
Author
|
@sbc100 you might like this change. Also I think we can remove that ancient setting on the Emscripten side? |
tlively
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just not used anywhere. A long time ago asm2wasm and s2wasm
used it, but both were removed.
Emscripten no longer uses this after we switched to the LLVM wasm backend:
https://emscripten.org/docs/tools_reference/settings_reference.html#:~:text=BINARYEN_TRAP_MODE%3A%20The%20wasm%20backend%20does%20not%20support%20a%20trap%20mode%20(it%20always%20clamps%2C%20in%20effect)%20(Valid%20values%3A%20%5B%2D1%5D)