TypeScript globals & Module class#8881
Draft
chharvey wants to merge 10 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second PR as part of #8826. This PR adds global functions, accessible from the
binaryennamespace. Also sets up theModuleclass and some instance methods.This PR is stacked on #8861 (i.e. it depends on that being merged first. the diff will be easier to compare once that happens, or you can compare here).
Adds 1 deprecation: the global function
getSideEffects()is deprecated in favor of the instance methodModule#getSideEffects(). The global function is still supported but it will log a warning to console:Some global functions are still commented out as they depend on Expression classes: the
Expression()function (called withoutnew), returns a class instance containing information about a wasm expression, and thegetExpressionInfofunction, which similarly returns a JSON object. Internally they depend on anEXPRESSION_TYPE_REGISTRYmap. These will be uncommented once the Expression class & subclasses are added in a future PR (for a preview, see #8826).