[3.x] Add a failing test for rendering a partial inside a collection rendering - #2674
Open
jcoyne wants to merge 1 commit into
Open
[3.x] Add a failing test for rendering a partial inside a collection rendering#2674jcoyne wants to merge 1 commit into
jcoyne wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This is a bug report, of a regression in 3.25 (from 3.24).
We get this error when rendering a partial from within a rendered component:
I believe this was introduced by ce1c920
on this line here: ce1c920#diff-b69c75ffd85596e0b5fca1327059ecf3b2930f3f77004c78a268fa85e8ec8d9eL83
The old
||=silently masked anil. The new code keys offinstance_variable_defined?, so an explicitly-stashednilis now honored.I think we can fix this by adding:
at base.rb:91.