Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
chrismaree
left a comment
There was a problem hiding this comment.
Reviewed against N-01 / FRO-151 at da6cb0d. The self-delegatecall has a zero-length output area, and failure processing copies only min(returndatasize(), 256) before hashing. This closes the unbounded parent-frame returndata copy/hash path while preserving caller context and child rollback. The temporary memory at the free-memory pointer is consumed within the assembly block; only the selector/hash escape. Empty/short payload handling and successful returndata discard are consistent with the documented behavior.
The patterned-prefix assertions address the earlier feedback, and the limited-gas regression checks that an earlier proposal survives a later 512 KiB revert. Existing child gas-starvation/insufficient outer-gas limits remain explicitly documented. Static code and test review with Solidity 0.8.30 memory-safety documentation; no tests or builds run.
Bound
TryMulticallfailure-data copying and hashing to the first 256 bytes. A child returning a large revert payload no longer forces the parent to allocate and hash the entire payload. Successful return data is discarded; event documentation now specifies prefix-hash semantics.Base: #77. Tracks FRO-151 (N-01).
Validation: all 52 SignedProposer unit tests pass. The new regression fails on the base and passes with the fix: a successful proposal survives a subsequent 512 KiB revert under a 2M-gas batch limit. Failure tests use nonzero patterned returndata and verify both the selector and the first-256-byte hash. Formatting and diff checks pass.
This bounds failure-metadata processing; existing child gas-starvation and insufficient outer-gas limitations still apply.