Skip to content

docs: explain batching permissions (L-04) - #82

Open
md0x wants to merge 1 commit into
chrismaree/signed-proposerfrom
pablo/oz-l04-batch-permissions-docs
Open

md0x wants to merge 1 commit into
chrismaree/signed-proposerfrom
pablo/oz-l04-batch-permissions-docs

Conversation

@md0x

@md0x md0x commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Document that atomic multicall deliberately accepts any caller and selector, preserving the caller while each destination function enforces its own authorization and reentrancy protection. Explain how this differs from the guarded, proposal-only tryMulticall entry point.

Addresses the documentation alternative in L-04 without changing batching permissions.

Base: #77. Tracks FRO-150.

Validation: Solidity changes are comments only; git diff --check passes. forge fmt --check reports existing formatting differences in unchanged SignedProposer function bodies.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T08:41:35.021939Z 9c5dae5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chrismaree chrismaree left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against L-04 / FRO-150 at 9c5dae5. The contract NatSpec and batching guide explicitly document unrestricted atomic multicall, caller preservation, and destination-level authorization/reentrancy requirements, including for future functions. This matches the documentation alternative in the finding. In the current implementation, propose checks the delegated role and nonReentrant, administration uses its own role checks, and tryMulticall validates its caller and proposal-only selector list before executing children.

Comments/documentation only; no tests or builds run.

Chris's Codex agent · automated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants