Skip to content

chore: v2 runview - split task annotations into user and system section - #2607

Merged
maxy-shpfy merged 1 commit into
masterfrom
08-03-chore_v2_runview_-_split_task_annotations_into_user_and_system_section
Aug 13, 2026
Merged

chore: v2 runview - split task annotations into user and system section#2607
maxy-shpfy merged 1 commit into
masterfrom
08-03-chore_v2_runview_-_split_task_annotations_into_user_and_system_section

Conversation

@maxy-shpfy

@maxy-shpfy maxy-shpfy commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Task annotations in the Run View are now split into two distinct sections: Task Annotations (user-defined) and System Annotations (system-defined, based on the SYSTEM_ANNOTATIONS list). User annotations are shown expanded by default, while system annotations are collapsed. Either section is only rendered if it contains at least one annotation.

Screenshots (if applicable)

Before After
image.png
image.png

Test Instructions

  1. Open a run in the Run View that has task nodes with annotations.
  2. Verify that user-defined annotations appear under the Task Annotations section.
  3. Verify that system-defined annotations (keys matching SYSTEM_ANNOTATIONS) appear under the System annotations section, collapsed by default.
  4. Verify that if only one type of annotation exists, only the relevant section is rendered.

Additional Comments

UX is consistent with the Editor counter part

maxy-shpfy commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 08-03-chore_v2_runview_-_split_task_annotations_into_user_and_system_section/26c8063

@maxy-shpfy
maxy-shpfy marked this pull request as ready for review August 3, 2026 18:57
@maxy-shpfy
maxy-shpfy requested a review from a team as a code owner August 3, 2026 18:57
@@ -27,13 +28,36 @@ function formatAnnotationValue(value: unknown): string {
export function getTaskAnnotationSections(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(AI-assisted)

[nit] Could we pin this split behavior with a small focused test?

This helper now carries the user/system classification, empty-section omission, and expanded/collapsed defaults, but none of those rules are exercised by an automated test. Mixed, user-only, system-only, and empty cases would give this stack useful regression coverage.

@Volv-G Volv-G left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(AI-assisted) Reviewed as the top of the #2606#2607 stack; no blocking issues found.

@maxy-shpfy
maxy-shpfy force-pushed the 08-03-chore_v2_runview_-_split_task_annotations_into_user_and_system_section branch from ad573f2 to 01568c0 Compare August 4, 2026 17:52
@maxy-shpfy
maxy-shpfy force-pushed the 08-03-fix_v2_runview_-_add_task_annotations_section branch from a41e4f9 to aa1b850 Compare August 4, 2026 17:52
@maxy-shpfy
maxy-shpfy changed the base branch from 08-03-fix_v2_runview_-_add_task_annotations_section to graphite-base/2607 August 4, 2026 17:56
@maxy-shpfy
maxy-shpfy force-pushed the 08-03-chore_v2_runview_-_split_task_annotations_into_user_and_system_section branch from 01568c0 to 6ac8c9d Compare August 4, 2026 18:00
@graphite-app
graphite-app Bot changed the base branch from graphite-base/2607 to master August 4, 2026 18:01
@maxy-shpfy
maxy-shpfy force-pushed the 08-03-chore_v2_runview_-_split_task_annotations_into_user_and_system_section branch from 6ac8c9d to a0d06f6 Compare August 4, 2026 18:01

@camielvs camielvs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

maxy-shpfy commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Aug 13, 6:40 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 13, 6:41 PM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 13, 6:45 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy
maxy-shpfy force-pushed the 08-03-chore_v2_runview_-_split_task_annotations_into_user_and_system_section branch from a0d06f6 to 26c8063 Compare August 13, 2026 18:41
@maxy-shpfy
maxy-shpfy merged commit cf2ed8e into master Aug 13, 2026
17 checks passed
@maxy-shpfy
maxy-shpfy deleted the 08-03-chore_v2_runview_-_split_task_annotations_into_user_and_system_section branch August 13, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants