Skip to content

fix: v2 - support value and default in input nodes - #2589

Merged
maxy-shpfy merged 1 commit into
masterfrom
07-29-fix_v2_-_support_value_and_default_in_input_nodes
Jul 30, 2026
Merged

fix: v2 - support value and default in input nodes#2589
maxy-shpfy merged 1 commit into
masterfrom
07-29-fix_v2_-_support_value_and_default_in_input_nodes

Conversation

@maxy-shpfy

@maxy-shpfy maxy-shpfy commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Introduces a distinct value field for pipeline inputs that sits above defaultValue in the resolution hierarchy. When a user sets a value in the Input Details panel, it now calls setInputValue, which sets both value and defaultValue on the input simultaneously. The displayed label has been renamed from "Default Value" to "Value", and the resolved display uses value ?? defaultValue so that an explicitly set value takes precedence. A "Use as default" indicator has also been added to the input label area.

Screenshots (if applicable)

Screen Recording 2026-07-29 at 12.40.03 PM.mov (uploaded via Graphite)

Test Instructions

  1. Open a pipeline in the editor and select an input node.
  2. In the Input Details panel, confirm the field is now labelled "Value" with a "Use as default" indicator.
  3. Enter a value and confirm it is reflected on the node card, taking precedence over any existing default value.
  4. Confirm undo/redo correctly reverts the value change.
  5. Confirm that pipelines with existing default values continue to display correctly when no explicit value is set.

Additional Comments

Copy link
Copy Markdown
Collaborator Author

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 07-29-fix_v2_-_support_value_and_default_in_input_nodes/4625235

@maxy-shpfy
maxy-shpfy marked this pull request as ready for review July 29, 2026 19:42
@maxy-shpfy
maxy-shpfy requested a review from a team as a code owner July 29, 2026 19:42

maxy-shpfy commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jul 30, 5:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 30, 5:16 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy
maxy-shpfy force-pushed the 07-29-fix_v2_-_support_value_and_default_in_input_nodes branch from 1b7b798 to 4625235 Compare July 30, 2026 17:10
@maxy-shpfy
maxy-shpfy merged commit 0c510ff into master Jul 30, 2026
16 checks passed
@maxy-shpfy
maxy-shpfy deleted the 07-29-fix_v2_-_support_value_and_default_in_input_nodes branch July 30, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants