Skip to content

ci: improve bundle size PR table - #8148

Merged
schiller-manuel merged 1 commit into
mainfrom
ci/bundle-size-pr-table
Aug 22, 2026
Merged

ci: improve bundle size PR table#8148
schiller-manuel merged 1 commit into
mainfrom
ci/bundle-size-pr-table

Conversation

@Sheraff

@Sheraff Sheraff commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • show absolute values and deltas from main in the Current gzip, Initial gzip, Raw, and Brotli cells
  • remove the standalone delta column and percentage deltas
  • parse secondary metric baselines from benchmark history and report scenarios when any metric changes
  • wrap trend sparklines in <pre> for consistent rendering

Sample output

Scenario Current (gzip) Initial (gzip) Raw Brotli Trend
react-router.full 123.4 KiB
+2 B
101.2 KiB
-4 B
400.8 KiB
+12 B
110.3 KiB
0 B
▁▂▃▄▅▆▇█

Testing

  • CI=1 NX_DAEMON=false pnpm nx run @benchmarks/bundle-size:test:unit --outputStyle=stream --skipRemoteCache
  • generated a report against the current gh-pages bundle-size history
  • git diff --check

Summary by CodeRabbit

  • New Features

    • Bundle-size reports now show current values and signed changes for gzip, initial gzip, raw, and Brotli sizes.
    • Reports use clearer KiB/MiB formatting and improved spacing for readability.
    • Scenarios are retained when any tracked size metric changes, including secondary metrics.
  • Documentation

    • Updated benchmark documentation to describe the expanded size metrics and baseline comparisons.
  • Tests

    • Added coverage for missing baselines, metric-specific changes, and the updated report format.

@Sheraff
Sheraff requested a review from a team as a code owner August 21, 2026 22:21
@nx-cloud

nx-cloud Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 69c0103

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m View ↗

☁️ Nx Cloud last updated this comment at 2026-08-21 22:27:50 UTC

@pkg-pr-new

pkg-pr-new Bot commented Aug 21, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8148

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8148

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8148

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8148

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8148

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8148

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8148

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8148

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8148

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8148

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8148

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8148

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8148

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8148

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8148

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8148

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8148

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8148

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8148

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8148

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8148

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8148

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8148

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8148

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8148

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8148

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8148

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8148

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8148

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8148

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8148

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8148

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8148

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8148

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8148

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8148

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8148

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8148

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8148

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8148

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8148

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8148

commit: 69c0103

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

4 package(s) bumped directly, 19 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/react-router 1.170.31 → 1.170.32 Changeset
@tanstack/router-core 1.171.26 → 1.171.27 Changeset
@tanstack/solid-router 1.170.29 → 1.170.30 Changeset
@tanstack/vue-router 1.170.28 → 1.170.29 Changeset
@tanstack/react-start 1.168.48 → 1.168.49 Dependent
@tanstack/react-start-client 1.168.29 → 1.168.30 Dependent
@tanstack/react-start-rsc 0.1.47 → 0.1.48 Dependent
@tanstack/react-start-server 1.167.36 → 1.167.37 Dependent
@tanstack/router-cli 1.167.32 → 1.167.33 Dependent
@tanstack/router-generator 1.167.32 → 1.167.33 Dependent
@tanstack/router-plugin 1.168.34 → 1.168.35 Dependent
@tanstack/router-vite-plugin 1.167.34 → 1.167.35 Dependent
@tanstack/solid-start 1.168.46 → 1.168.47 Dependent
@tanstack/solid-start-client 1.168.28 → 1.168.29 Dependent
@tanstack/solid-start-server 1.167.35 → 1.167.36 Dependent
@tanstack/start-client-core 1.170.26 → 1.170.27 Dependent
@tanstack/start-plugin-core 1.171.38 → 1.171.39 Dependent
@tanstack/start-server-core 1.169.30 → 1.169.31 Dependent
@tanstack/start-static-server-functions 1.167.31 → 1.167.32 Dependent
@tanstack/start-storage-context 1.167.28 → 1.167.29 Dependent
@tanstack/vue-start 1.168.45 → 1.168.46 Dependent
@tanstack/vue-start-client 1.167.31 → 1.167.32 Dependent
@tanstack/vue-start-server 1.167.35 → 1.167.36 Dependent

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fa6160a3-9911-487b-9b63-2f7900a8a439

📥 Commits

Reviewing files that changed from the base of the PR and between cb281d7 and 69c0103.

📒 Files selected for processing (3)
  • benchmarks/bundle-size/README.md
  • scripts/benchmarks/bundle-size/pr-report.mjs
  • scripts/benchmarks/bundle-size/pr-report.test.mjs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The bundle-size report now tracks gzip, initial gzip, raw, and Brotli values. It preserves these metrics in baselines, reports signed per-metric deltas, skips only fully unchanged scenarios, and documents the expanded output.

Changes

Bundle size reporting

Layer / File(s) Summary
Metric parsing and baseline data
scripts/benchmarks/bundle-size/pr-report.mjs, scripts/benchmarks/bundle-size/pr-report.test.mjs
The report parses and stores gzip, initial-gzip, raw, and Brotli metrics. Formatting uses one decimal place and non-breaking spaces. Fixtures cover expanded historical metrics.
Multi-metric report generation
scripts/benchmarks/bundle-size/pr-report.mjs, scripts/benchmarks/bundle-size/pr-report.test.mjs, benchmarks/bundle-size/README.md
Scenario filtering compares all tracked metrics. Markdown output shows current values and signed deltas for each metric. Tests cover missing baselines and secondary-metric changes. Documentation describes the expanded report.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 69c01

This change updates bundle-size PR reporting to show absolute values, deltas, secondary metric changes, and consistently rendered trends; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 2 files. (1 skipped: 1 unsupported.) Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change to the bundle size PR table.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/bundle-size-pr-table

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

This pull request does not affect bundle size in any measured scenario.

@codspeed-hq

codspeed-hq Bot commented Aug 21, 2026

Copy link
Copy Markdown

Merging this PR will regress 6 benchmarks

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 11 improved benchmarks
❌ 6 regressed benchmarks
✅ 163 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory mem server error-paths redirect (react) 296.3 KB 319.5 KB -7.26%
Memory mem server peak-large-page (vue) 1 MB 1.1 MB -5.88%
Memory mem server server-fn-churn (vue) 345.7 KB 364.7 KB -5.21%
Memory mem client interrupted-navigations (vue) 352.7 KB 368.3 KB -4.21%
Simulation client-async-pipeline navigation loop (react) 102.8 ms 107.1 ms -4.02%
Memory mem server serialization-payload (vue) 4.4 MB 4.5 MB -3.24%
Memory mem server error-paths unmatched (react) 1,830.3 KB 417.7 KB ×4.4
Memory mem server error-paths not-found (vue) 2,071.7 KB 552.1 KB ×3.8
Memory mem server error-paths not-found (react) 435.6 KB 409.4 KB +6.39%
Memory mem server request-churn (react) 712.7 KB 670.7 KB +6.26%
Memory mem client unique-location-churn (vue) 463.2 KB 437.5 KB +5.86%
Memory mem server peak-large-page (solid) 1.1 MB 1.1 MB +5.46%
Memory mem server error-paths not-found (solid) 570 KB 546.7 KB +4.26%
Memory mem server error-paths redirect (solid) 373 KB 358.2 KB +4.13%
Memory mem client navigation-churn (solid) 589.5 KB 566.5 KB +4.07%
Simulation ssr global-mw server-fn (vue) 242.2 ms 234.7 ms +3.21%
Simulation ssr control-flow route headers (react) 303.3 ms 294 ms +3.18%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ci/bundle-size-pr-table (69c0103) with main (cb281d7)

Open in CodSpeed

@schiller-manuel
schiller-manuel merged commit d83a896 into main Aug 22, 2026
24 of 26 checks passed
@schiller-manuel
schiller-manuel deleted the ci/bundle-size-pr-table branch August 22, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants