Skip to content

chore(start): remove redundant splitChunks config from React plugin - #8136

Merged
schiller-manuel merged 1 commit into
TanStack:mainfrom
chenjiahan:chenjiahan/remove-redundant-react-split-chunks
Aug 22, 2026
Merged

chore(start): remove redundant splitChunks config from React plugin#8136
schiller-manuel merged 1 commit into
TanStack:mainfrom
chenjiahan:chenjiahan/remove-redundant-react-split-chunks

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

TanStack Start already configures Rsbuild to split async chunks. This prevents @rsbuild/plugin-react from adding its chunk groups, so splitChunks: false is redundant.

This PR removes the option from benchmarks, e2e fixtures, and docs without changing build output.

Summary by CodeRabbit

  • Improvements
    • React applications now use the default code-splitting behavior, enabling split chunks for improved bundle optimization.
    • Updated React examples, documentation, and end-to-end scenarios to reflect the default configuration.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b45a81b1-822c-4400-92e3-3cb381ab9e71

📥 Commits

Reviewing files that changed from the base of the PR and between cb281d7 and d555b35.

📒 Files selected for processing (11)
  • benchmarks/bundle-size/scenarios/react-start-full/rsbuild.config.ts
  • benchmarks/bundle-size/scenarios/react-start-minimal/rsbuild.config.ts
  • docs/start/framework/react/guide/server-components.md
  • e2e/react-start/basic/rsbuild.config.ts
  • e2e/react-start/css-inline/rsbuild.config.ts
  • e2e/react-start/custom-server-rsbuild/rsbuild.config.ts
  • e2e/react-start/deferred-hydration/rsbuild.config.ts
  • e2e/react-start/hmr/rsbuild.config.ts
  • e2e/react-start/rsbuild/rsbuild.config.ts
  • e2e/react-start/rsc-rsbuild/rsbuild.config.ts
  • e2e/react-start/rsc/rsbuild.config.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The React plugin configurations no longer pass splitChunks: false. Benchmarks, documentation, and end-to-end scenarios now use the plugin’s default split-chunk behavior.

Changes

React plugin default configuration

Layer / File(s) Summary
Remove explicit split-chunk disablement
benchmarks/bundle-size/scenarios/react-start-*/rsbuild.config.ts, docs/start/framework/react/guide/server-components.md, e2e/react-start/*/rsbuild.config.ts
All affected pluginReact calls now use default options instead of setting splitChunks: false.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to d555b

This PR removes redundant chunk-splitting configuration from React Start examples, benchmarks, and fixtures without an identified behavior regression; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: schiller-manuel

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the removal of the redundant splitChunks configuration from the React plugin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 10 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan chenjiahan changed the title refactor(start): remove redundant React splitChunks config chore(start): remove redundant React splitChunks config Aug 21, 2026
@chenjiahan chenjiahan changed the title chore(start): remove redundant React splitChunks config chore(start): remove redundant splitChunks config from React plugin Aug 21, 2026
@chenjiahan
chenjiahan marked this pull request as ready for review August 21, 2026 09:30
@nx-cloud

nx-cloud Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit d555b35

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 12m 6s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-21 21:09:21 UTC

@pkg-pr-new

pkg-pr-new Bot commented Aug 21, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8136

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8136

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8136

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8136

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8136

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8136

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8136

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8136

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8136

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8136

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8136

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8136

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8136

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8136

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8136

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8136

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8136

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8136

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8136

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8136

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8136

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8136

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8136

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8136

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8136

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8136

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8136

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8136

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8136

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8136

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8136

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8136

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8136

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8136

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8136

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8136

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8136

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8136

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8136

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8136

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8136

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8136

commit: d555b35

@codspeed-hq

codspeed-hq Bot commented Aug 21, 2026

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 5 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory mem server serialization-payload (solid) 4.6 MB 5.2 MB -12.67%
Memory mem client unique-location-churn (vue) 463.2 KB 510.4 KB -9.26%
Memory mem server error-paths redirect (react) 296.3 KB 311.7 KB -4.94%
Memory mem server error-paths error (solid) 970 KB 1,017.6 KB -4.68%
Simulation client-async-pipeline navigation loop (react) 102.8 ms 107.1 ms -3.99%
Memory mem server error-paths unmatched (react) 1,830.3 KB 424.8 KB ×4.3
Memory mem server error-paths not-found (vue) 2,071.7 KB 503.1 KB ×4.1
Memory mem server request-churn (react) 712.7 KB 664.8 KB +7.22%
Memory mem server server-fn-churn (vue) 345.7 KB 323.7 KB +6.82%
Memory mem server error-paths not-found (solid) 570 KB 547.5 KB +4.1%
Memory mem server error-paths redirect (solid) 373 KB 358.5 KB +4.06%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing chenjiahan:chenjiahan/remove-redundant-react-split-chunks (d555b35) with main (cb281d7)

Open in CodSpeed

@chenjiahan

Copy link
Copy Markdown
Contributor Author

These CI failures look like permission issues, the workflows couldn’t post comments or labels due to the fork’s read-only token.

@schiller-manuel
schiller-manuel merged commit aab01de into TanStack:main Aug 22, 2026
23 of 26 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/remove-redundant-react-split-chunks branch August 22, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants