chore(start): remove redundant splitChunks config from React plugin - #8136
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe React plugin configurations no longer pass ChangesReact plugin default configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR removes redundant chunk-splitting configuration from React Start examples, benchmarks, and fixtures without an identified behavior regression; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit d555b35
☁️ Nx Cloud last updated this comment at |
Merging this PR will regress 5 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server serialization-payload (solid) |
4.6 MB | 5.2 MB | -12.67% |
| ❌ | Memory | mem client unique-location-churn (vue) |
463.2 KB | 510.4 KB | -9.26% |
| ❌ | Memory | mem server error-paths redirect (react) |
296.3 KB | 311.7 KB | -4.94% |
| ❌ | Memory | mem server error-paths error (solid) |
970 KB | 1,017.6 KB | -4.68% |
| ❌ | Simulation | client-async-pipeline navigation loop (react) |
102.8 ms | 107.1 ms | -3.99% |
| ⚡ | Memory | mem server error-paths unmatched (react) |
1,830.3 KB | 424.8 KB | ×4.3 |
| ⚡ | Memory | mem server error-paths not-found (vue) |
2,071.7 KB | 503.1 KB | ×4.1 |
| ⚡ | Memory | mem server request-churn (react) |
712.7 KB | 664.8 KB | +7.22% |
| ⚡ | Memory | mem server server-fn-churn (vue) |
345.7 KB | 323.7 KB | +6.82% |
| ⚡ | Memory | mem server error-paths not-found (solid) |
570 KB | 547.5 KB | +4.1% |
| ⚡ | Memory | mem server error-paths redirect (solid) |
373 KB | 358.5 KB | +4.06% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing chenjiahan:chenjiahan/remove-redundant-react-split-chunks (d555b35) with main (cb281d7)
|
These CI failures look like permission issues, the workflows couldn’t post comments or labels due to the fork’s read-only token. |
TanStack Start already configures Rsbuild to split async chunks. This prevents
@rsbuild/plugin-reactfrom adding its chunk groups, sosplitChunks: falseis redundant.This PR removes the option from benchmarks, e2e fixtures, and docs without changing build output.
Summary by CodeRabbit