fix(start): migrate to Rsbuild splitChunks config - #8135
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe client Rsbuild configuration now uses v2 ChangesRsbuild chunk splitting
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change updates the build configuration to the supported split-chunk option while preserving async route splitting behavior; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 4337e7e
☁️ Nx Cloud last updated this comment at |
Merging this PR will regress 9 benchmarks
|
Summary
Rsbuild v2 deprecates
performance.chunkSplitin favor of the top-levelsplitChunksoption.This migrates the Start Rsbuild client config to
splitChunkswithpreset: 'none'andchunks: 'async', preserving the existing behavior of splitting only async route chunks.The Vue Start e2e config no longer supplies the deprecated override.
Related Links
Summary by CodeRabbit
Bug Fixes
Chores