Skip to content

fix(solid-router): defer adapter hydration payloads - #8105

Open
Fnine59 wants to merge 1 commit into
TanStack:solid-router-v2-prefrom
Fnine59:fix/tanstack-router-solid-ssr-adapter-8104
Open

fix(solid-router): defer adapter hydration payloads#8105
Fnine59 wants to merge 1 commit into
TanStack:solid-router-v2-prefrom
Fnine59:fix/tanstack-router-solid-ssr-adapter-8104

Conversation

@Fnine59

@Fnine59 Fnine59 commented Aug 18, 2026

Copy link
Copy Markdown

Fixes #8104.

Solid's SSR serializer can emit hydration data before the router bootstrap and before hydrate() installs the custom adapter map. Adapter expressions in those eager scripts therefore read $_TSR.t too early.

This change routes a Solid hydration payload through the router's existing buffer once a custom adapter participates in serialization. If the payload arrives before the bootstrap, it creates only an early buffer that the real bootstrap adopts. The complete payload and all later serializer chunks stay in order, so hydrate() installs the adapter map and runs the real fromSerializable function before Solid hydration consumes the value; there is no identity fallback.

Regression coverage exercises both missing-$_TSR and missing-.t timing, payloads that arrive after initialization, preservation of the pre-bootstrap queue, restoration of a Money instance and its method, and the unchanged default serializer path when no adapters are configured.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ce16ba63-eb9f-4c5e-b647-50ff482da9fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant