fix(solid-router): defer adapter hydration payloads - #8105
Open
Fnine59 wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8104.
Solid's SSR serializer can emit hydration data before the router bootstrap and before
hydrate()installs the custom adapter map. Adapter expressions in those eager scripts therefore read$_TSR.ttoo early.This change routes a Solid hydration payload through the router's existing buffer once a custom adapter participates in serialization. If the payload arrives before the bootstrap, it creates only an early buffer that the real bootstrap adopts. The complete payload and all later serializer chunks stay in order, so
hydrate()installs the adapter map and runs the realfromSerializablefunction before Solid hydration consumes the value; there is no identity fallback.Regression coverage exercises both missing-
$_TSRand missing-.ttiming, payloads that arrive after initialization, preservation of the pre-bootstrap queue, restoration of aMoneyinstance and its method, and the unchanged default serializer path when no adapters are configured.