Keep the burn-in Generate button reachable on short screens - #14550
Merged
Conversation
On a 1366x768 laptop a maximized "Generate video with burned-in subtitle" window has about 700 DIPs of client height, but the settings area needs more (the preview row alone carries a 400 minimum). UiUtil clamps the window to the working area, so the rows below the fold - the Generate / OK / Cancel row - were clipped off the screen with no way to reach them. Wrap the settings grid (settings column, cut, preview, audio, video info, batch list) in a ScrollViewer and keep the progress bar and the button row outside it. The grid's MinHeight follows the viewport so the star preview row still fills tall windows exactly as before; only when the viewport is shorter than the content minimum does the area scroll. The left column's own ScrollViewer is no longer needed: the outer one clips the same overflow (#13904). Fixes #14360 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
oiomaker
pushed a commit
to oiomaker/subtitleedit
that referenced
this pull request
Sep 5, 2026
Bump the version to v5.2.0-rc3 in Se.cs and English.json, and add the change-log section covering the 32 pull requests merged since v5.2.0-rc2 (every merged PR ancestor-checked against the rc2 tag). Grouped: the two audio.cpp per-line clone fixes (SubtitleEdit#14511, SubtitleEdit#14512) share a line, as do the two waveform playback fixes (SubtitleEdit#14528, SubtitleEdit#14532) and the two short-screen dialog fixes (SubtitleEdit#14550, SubtitleEdit#14551). Left out as internal-only: the UiTickPump timer follow-up (SubtitleEdit#14543) and the WhisperX log-noise env vars (SubtitleEdit#14513). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14360
The reporter's screenshot is 1366x768 with the window maximized: about 700 DIPs of client height, less than the burn-in settings area needs (the preview row alone carries a 400 minimum). UiUtil clamps the window to the working area, so the Generate / OK / Cancel row was clipped off the bottom of the screen and could not be reached.
Change
ScrollViewer; the progress bar and button row stay outside it, pinned at the bottom.MinHeightfollows the scroll viewer's viewport, so the star preview row keeps filling tall windows exactly as before. Only when the viewport is shorter than the content minimum does the area scroll.ScrollVieweris gone; the outer one clips the same overflow (Video generating loading bar UI error #13904).Tests
BurnInWindowTestsupdated for the two-level grid, plus two new tests: the button row stays inside a 697 DIP tall window while the settings area scrolls, and the settings grid grows with the window without scrolling when there is room. All 10 pass.Headless render at the reporter's client size (1366x697): Generate row visible, settings area scrolls.
🤖 Generated with Claude Code