Update dependency mocha to v12.0.1 - #2817
Merged
Merged
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Firefox now reports 2 call frames for the BiDi javascriptException log entry on the test fixture page instead of 3, causing this pre-existing assertion to fail across CI jobs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf6o8N193Wi1aJKHWf7j1T
…ipt test The unpin call could race ahead of the first navigation's async console message, leaving the pinned script still active for the second navigation and causing an extra count on Windows CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf6o8N193Wi1aJKHWf7j1T
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Waiting on a promise resolved by the console handler is more reliable and faster than an arbitrary delay(3000) before unpinning. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf6o8N193Wi1aJKHWf7j1T
On Windows, unpin() resolving client-side did not guarantee the preload script was deregistered before the next navigation, so the pinned script still fired once more. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf6o8N193Wi1aJKHWf7j1T
removePreloadScript() acks immediately but the removal appears to lag by one navigation on Windows geckodriver, so the pinned script still fired on the very next get(). Navigating to about:blank first absorbs that stray execution deterministically, without an arbitrary wait. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf6o8N193Wi1aJKHWf7j1T
Temporary diagnostic to determine whether the extra pinned-script execution happens on the first navigation or after unpin, since prior fix attempts (delay, promise-wait, flush navigation) all failed identically at count=2. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf6o8N193Wi1aJKHWf7j1T
Diagnostic logging showed the pinned script's console message fires twice on a single navigation on Windows Firefox, unrelated to unpin - count was already 2 right after the first get(), and unchanged after unpin() and the second navigation in every sample. The test should verify unpin() prevents further executions, not assume a fixed count from the first load. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf6o8N193Wi1aJKHWf7j1T
diemol
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
12.0.0→12.0.1Release Notes
mochajs/mocha (mocha)
v12.0.1Compare Source
🩹 Fixes
📚 Documentation
🧹 Chores
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.