⚡ Optimize MarqueeSection scroll performance - #18
Conversation
… reconciliation Co-authored-by: SayanthRock <202829406+SayanthRock@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔 |
|
Unable to locate .performanceTestingBot config file |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
🤖 CodeAnt AI — Review Status
|
|
You've hit your review limit for the week, but don't worry you'll get some more next week! Contact us at hello@zenable.io if you want this rate limit to go away |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 52 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
User description
💡 What:
Refactored
MarqueeSection.tsxto stop using React'suseStatefor tracking the scroll offset. Instead, I introduceduseRefhooks to directly target the two animated row containers (row1Refandrow2Ref) and modified theirstyle.transformproperties directly inside arequestAnimationFrame-throttled scroll event listener.🎯 Why:
Previously, the component bound a scroll event listener that called
setOffseton every scroll tick. Browsers typically fire scroll events faster than the standard 60fps frame rate (often up to 100+ Hz). Sinceoffsetwas a React state variable, every single scroll event forced React to reconcile the virtual DOM for the entireMarqueeSectioncomponent, which includes 63 heavy<img>elements (33 in row 1, 30 in row 2). This constant, heavy reconciliation on the main thread leads to stuttering, layout thrashing, and scroll jank.📊 Measured Improvement:
MarqueeSectionre-rendering fully on every single scroll tick. The main thread would be bogged down with continuous VDOM diffing.MarqueeSectionrenders exactly once during the initial mount. During scrolling, the event listener modifies the DOM styles directly (row1Ref.current.style.transform), completely bypassing the React reconciliation cycle.N(where N is the number of scroll events) to 0. By additionally throttling the style updates withrequestAnimationFrame, the direct DOM mutations are perfectly synced with the device's refresh rate, minimizing CPU overhead drastically and ensuring a butter-smooth marquee animation.PR created automatically by Jules for task 508832689114683390 started by @SayanthRock
CodeAnt-AI Description
Smooth marquee movement while scrolling
What Changed
Impact
✅ Smoother scrolling through the marquee✅ Lower rendering work during scroll✅ Fewer visible animation stutters💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.