feat: add xrun reporting on AAudio, macOS, PipeWire and WASAPI - #1268
Merged
Conversation
Not present in bindgen output on the libspa version CI links against.
roderickvd
added a commit
that referenced
this pull request
Jul 21, 2026
AUDCLNT_BUFFERFLAGS_DATA_DISCONTINUITY is documented as undefined on the first GetBuffer call after Start, and in practice WASAPI sets it unconditionally there since there's no previous packet to correlate a device position against. Since #1268 we report that as a real Xrun, so every capture stream starts with a spurious error. Grab the device position from GetBuffer (previously discarded with None) and only trust the discontinuity flag once it's nonzero, the same guard WebRTC's WASAPI backend uses for the same caveat. Fixes #1273
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know how I missed this before, but here they are.
Still missing: