Proper Error Handling#290
Merged
Merged
Conversation
8814b0c to
02269fd
Compare
02269fd to
3863d6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes many (many (many)) cases of panics and
unwrap()s within baseview, and replaces them with proper error handling:Errorfor all window-related operations.HandlerErrorthat can coalesce any error type, to be returned inWindowHandlermethods.WindowHandler::on_framecan now return errors, which will properly destroy the window if they do.WindowHandler::resizedcan now return errors, which will revert the resize operation if they do.create_windownow returns aResult, and theWindowHandlerbuilder it takes is now also fallible.WindowContextnow return anErrorwhen they fail, instead of panicking.