feat: make cacheAllConnectionPairs public#10149
Merged
Merged
Conversation
1 task
lizschwab
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes RaspberryPiFoundation/blockly-samples#2708 (Requires plugin update as well)
Proposed Changes
BlockDragStrategy.cacheAllConnectionPairs()public so consumers can refresh the cached connection pairs during an active drag.Reason for Changes
BlockDragStrategycaches valid connection pairs when a drag begins. If another block changes shape during the drag, such as a plugin dynamically adds an input, the cache does not contain the new connection. This is required to make@blockly/block-dynamic-connectionwork correctly with keyboard move mode.Cached connections are also necessary for ensuring properly verbose move mode announcements (e.g. disambiguating similar connections on a neighbour), but this information was missing for pointer drags.
Test Coverage
Added Mocha tests:
Documentation
Additional Information
See RaspberryPiFoundation/blockly-samples#2751 for corresponding plugin change.