Conversation
Add unit tests for mapInputItemToOfferItem, the normalizer every createOrder input item passes through on its way to a Seaport OfferItem. It was previously only exercised indirectly through the hardhat-backed create-order specs, so these fast, isolated units pin its per-variant behavior: basic ERC721/ERC1155 items, criteria items (explicit root and identifiers-derived merkle root), the amount defaults each variant applies, and native vs ERC20 currency items.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
+ Coverage 98.27% 98.86% +0.59%
==========================================
Files 35 45 +10
Lines 14526 17775 +3249
Branches 660 913 +253
==========================================
+ Hits 14276 17574 +3298
+ Misses 245 194 -51
- Partials 5 7 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Taken, thanks. I checked all ten assertions against Landing in #972, which stacks several contributions because four of them collided in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mapInputItemToOfferItemis the single normalizer everycreateOrderinput item passes through on its way to a SeaportOfferItem, fanning aCreateInputItemout into the fully-populated{ itemType, token, identifierOrCriteria, startAmount, endAmount }shape and applying the amount defaults each variant relies on.It was previously only exercised indirectly through the hardhat-network-backed create-order specs. This adds fast, isolated unit tests in
test/utils/order.spec.tsthat pin its branch-by-branch behavior:1)endAmountdefaults to the start amount; ascending amounts preserved)identifiersTesting
hardhat test(all order util specs pass, 19 total)