Merge nodes by links validation case - #1507
Open
Jerry-Jinfeng-Guo wants to merge 26 commits into
Open
Conversation
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Jerry-Jinfeng-Guo
added
feature
5 tasks
mgovers
previously approved these changes
Jul 29, 2026
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
This reverts commit e40302d. Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
This reverts commit eeb760b. Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
figueroa1395
reviewed
Aug 4, 2026
figueroa1395
left a comment
figueroa1395
left a comment
Member
There was a problem hiding this comment.
Some early input.
I'm missing a test case with a link that is disconnected at one side. That partially disconnected link should have "null" output and it isn't part of a supernode.
Comment on lines
+14
to
+15
| "p": 0, | ||
| "q": 0 |
Member
There was a problem hiding this comment.
I think these values are non-zero for this node because the source is attached to it.
I see this may be relevant for other test cases as well.
Member
There was a problem hiding this comment.
Is there any difference between this test and tests/data/power_flow/handling-of-links/merge-nodes-by-links-1-line-line-to-super-node-itself-II/input.json besides the nodes where line 15 is attached to?
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Jerry-Jinfeng-Guo
marked this pull request as ready for review
August 14, 2026 08:32
Jerry-Jinfeng-Guo
enabled auto-merge
August 14, 2026 08:35
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the validation test cases for feature merge nodes connected by links to suber nodes