Use propagate_metadata_to_children for uprating in breakdown parameters - #9429
Open
RajveerKapoor wants to merge 28 commits into
Open
Use propagate_metadata_to_children for uprating in breakdown parameters#9429RajveerKapoor wants to merge 28 commits into
RajveerKapoor wants to merge 28 commits into
Conversation
Removed metadata uprating sections from various filing statuses and consolidated uprating information under the main metadata section.
Removed redundant metadata for uprating from each filing status and consolidated it under the main metadata section.
Added uprating parameter with rounding details to the property tax credit amount configuration. Removed redundant uprating metadata from each filing status.
Added uprating metadata for property tax credit limits.
Added uprating metadata to the property tax credit parameters for non-elderly households, specifying rounding details.
Added uprating field to the California tax exemption amounts for various filing statuses.
Added uprating metadata to the California AMTI exemption threshold for various filing statuses.
Removed redundant metadata sections for each filing status and added uprating to the main metadata.
Removed redundant metadata for uprating from income thresholds.
Removed redundant metadata for uprating from income thresholds.
Updated the Maryland standard deduction configuration by adding uprating metadata and cleaning up references.
Removed redundant metadata and uprating details for each filing status. Updated reference links for Maryland tax forms and instructions.
Added uprating metadata for income tax surcharge thresholds while removing redundant metadata from each filing status.
Removed redundant uprating metadata from income limits for various filing statuses.
Added uprating metadata for Child Tax Credit phase-out increment.
Updated the Rhode Island Child Tax Credit phase-out threshold YAML file by adding uprating metadata and removing redundant metadata sections from each filing status.
Added uprating metadata for standard deduction amounts and removed redundant metadata sections.
Simplified uprating metadata in breakdown parameters using `propagate_metadata_to_children`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5576.
Breakdown parameters currently repeat the same
upratingblock under every filing-status child. Since these files already setpropagate_metadata_to_children: truein their top-level metadata, the uprating can be declared once at the top level and propagated to each child, as intended by #5570.This PR hoists the duplicated per-child uprating blocks into the top-level metadata of the 27 remaining breakdown parameter files where every child uprates identically (1 federal, 21 state, 5 contrib). Behaviour is unchanged:
propagate_parameter_metadatacopies the parent's metadata into every child, and each removed child block was identical to the hoisted one. I verified this by loading the parameter tree before and after with policyengine-core and comparing every child's effective uprating - all identical.Three files were left untouched because their children uprate differently or only some children uprate: