Enhance platform detection in windows? method - #245
Open
nmburgan wants to merge 1 commit into
Open
Conversation
Update windows? method to improve platform detection. The previous method was not reliable when attempting to run tests via the `bundle exec` from a Cygwin shell. Ruby has largely moved to looking at RUBY_PLATFORM instead anyway.
Member
Author
|
There are other problems trying to run specs on Windows. May not be worth it in case this breaks something, but leaving it open for now in case we fix that up later. |
Contributor
|
I don't know about this. It kinda depends on how |
bastelfreak
approved these changes
Nov 22, 2025
bastelfreak
left a comment
bastelfreak
left a comment
Contributor
There was a problem hiding this comment.
To me this looks like the better implementation, but I am really not a windows expert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update windows? method to improve platform detection. The previous method was not reliable when attempting to run tests via the
bundle execfrom a Cygwin shell. Ruby has largely moved to looking at RUBY_PLATFORM instead anyway.