Make OpenBLAS's usage of OpenMP respect openblas_set_num_threads()#5808
Open
nh2 wants to merge 3 commits into
Open
Make OpenBLAS's usage of OpenMP respect openblas_set_num_threads()#5808nh2 wants to merge 3 commits into
openblas_set_num_threads()#5808nh2 wants to merge 3 commits into
Conversation
…ixes OpenMathLib#5806. Until now, the code in `num_cpu_avail()`, if (blas_cpu_number != openmp_nthreads) { goto_set_num_threads(openmp_nthreads); } would just always set the threads back to OpenMP's thread count.
|
Would be nice to get a fix merged, if someone has time to review. |
Contributor
|
@frbg - @itamarst is working with me and @kumaraditya303 on improving support for free-threading in Python packages. He's identified the issue this PR in particular fixes as the cause of substantial CPU oversubscription in scikit-learn using the threading joblib backend. We'd appreciate your eyes on this and the original issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5806.
Also
openblas_set_num_threads_local()does, see Add BLAS extension openblas_set_num_threads_local() #4425 (comment)num_cpu_avail()I complained about inopenblas_set_num_threads()is silently overridden when built withUSE_OPENMP#5806 (comment)Reviewing by commit is recommended.