fix(s3): close ranged response bodies - #3095
Merged
Merged
Conversation
- Close the acquired range reader before releasing its link. - Cover close order and repeated S3 body closure. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
nostalume
marked this pull request as ready for review
September 19, 2026 11:25
This was referenced Sep 19, 2026
jyxjjj
approved these changes
Sep 19, 2026
pikachuren
reviewed
Sep 21, 2026
pikachuren
left a comment
Collaborator
There was a problem hiding this comment.
🙏 感谢 @nostalume 提交!
🤖 AI 自动审核声明:本评审报告由 AI 自动生成,当前使用 Claude Opus 5 模型进行分析。
🎯 结论
✅ Approve — 代码质量良好,建议合并
📖 概要
fix(s3): close ranged response bodies
📊 评审结果
改动合理,无重大问题发现。代码逻辑清晰,符合项目规范。
🎯 结论:✅ Approve — 建议合并
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Close the range body acquired by S3
GetObjectbefore releasing its link. PreviouslyObject.Contents.Closereleased only the link, leaving driver or HTTP range bodies open. The returned body now owns both resources through the existing multi-closer, preserving close errors and making repeated caller closes harmless.The regression exercises the public backend boundary and verifies response bytes plus exact body-before-link close order. This does not change public API, configuration, storage format, lookup/cache behavior, metadata, range calculation, or S3 error mapping.
/ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Testing / 测试
go test ./...(not run; the complete affected package was tested)go test ./server/s3 -count=1on Windows/amd64, Go 1.27.1go vet ./server/s3on Windows/amd64, Go 1.27.1go test ./server/s3 -run '^TestGetObjectClosesRangeBodyBeforeLink$' -count=10on Windows/amd64, Go 1.27.1CGO_ENABLED=1 go test -race ./server/s3 -run '^TestGetObjectClosesRangeBodyBeforeLink$' -count=3on Linux/amd64 (tumbleweed WSL 2), Go 1.27.1Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 已格式化变更代码。
/ 草稿 PR,尚未请求维护者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Tests / 测试
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。