Conversation
- Reuse HTTP precondition checks for existing and missing upload targets - Support repeated entity-tag headers and reject empty If-Match lists - Preserve nanosecond precision in metadata-based ETags - Return 204 for overwrites and retain ETags in buffered PUT responses - Add regression tests for preconditions, ranges, and ETag changes Co-authored-by: Codex <267193182+codex@users.noreply.github.com> Signed-off-by: jyxjjj <16695261+jyxjjj@users.noreply.github.com>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
PUT 在写入前检查 If-Match、If-None-Match 和 If-Unmodified-Since,条件不满足时返回 412。
支持目标不存在、通配符、强弱 ETag、多个标签和条件优先级。
创建文件返回 201,覆盖文件返回 204,并保留 PUT 响应中的 ETag。
无内容哈希时保留修改时间的纳秒精度,修复同秒、同大小更新导致的 ETag 碰撞。此类 ETag 仍依赖存储驱动提供的修改时间和大小。
This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Fixes #3065
Testing / 测试
go test -mod=readonly -race -count=1 -v internal/net/preconditions.go internal/net/preconditions_test.gogit diff --checkgo test ./...go test -mod=readonly ./server/webdav ./server/common因缺失依赖而在准备阶段失败。新增 ETag 测试尚未执行。测试禁用了依赖下载,未安装任何依赖。Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况格式化变更代码。
/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含归属信息。
I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。