Skip to content

fix: sync acp-providers.json with openhands-sdk - #339

Closed
neubig wants to merge 1 commit into
mainfrom
fix-acp-drift
Closed

fix: sync acp-providers.json with openhands-sdk#339
neubig wants to merge 1 commit into
mainfrom
fix-acp-drift

Conversation

@neubig

@neubig neubig commented Aug 11, 2026

Copy link
Copy Markdown
Member

Why

The validate-acp-providers CI check has been failing on main because src/models/acp-providers.json drifted from the Python source of truth in openhands-sdk. This was blocking dependabot PRs (#325, #324) that are otherwise green.

Summary

  • Updated src/models/acp-providers.json to match the current ACP_PROVIDERS in openhands-sdk main, including version bumps and model label changes.

How to Test

pip install "openhands-sdk @ git+https://github.com/OpenHands/software-agent-sdk@main#subdirectory=openhands-sdk"
python scripts/check-acp-drift.py

Should print OK: src/models/acp-providers.json matches openhands-sdk (3 providers).

Type

  • Bug fix
  • Feature
  • Refactor
  • Breaking change
  • Docs / chore

This PR was created by an AI agent (OpenHands) on behalf of the user.

@github-actions github-actions Bot added the type: fix A bug fix label Aug 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Endpoint audit

⚠️ 7 actionable Agent Server contract divergence(s) · report-only

Contract: pinned release artifact

Category Count
Actionable client-only calls 0
Actionable server-only operations 7
Documented non-divergences 13
Agent Server contract operations 117
Audited handwritten client endpoints 119

Actionable client-only calls (0)

none

Actionable server-only operations (7)

  • GET /api/conversations/{}/events
  • GET /api/file/archive
  • GET /api/git/commits
  • GET /api/git/commits/{}/changes
  • GET /api/init
  • POST /api/conversations/{}/load_plugin
  • POST /api/init
Documented non-divergences (13)

Client calls intentionally absent from the filtered contract (11)

  • GET /
  • GET /alive
  • GET /health
  • GET /ready
  • GET /server_info

Reason: Operational Agent Server endpoints intentionally excluded from the filtered public release artifact.
Owner: OpenHands runtime maintainers

  • DELETE /api/meta-profiles/{}
  • GET /api/meta-profiles
  • GET /api/meta-profiles/{}
  • POST /api/meta-profiles/{}
  • POST /api/meta-profiles/{}/activate

Reason: Client-ahead API stacked on the pending Agent Server meta-profiles implementation.
Owner: OpenHands SDK maintainers
Tracking: OpenHands/software-agent-sdk#3744

  • POST /api/profiles/{}/validate

Reason: Client-ahead API stacked on the pending Agent Server pre-flight LLM validation endpoint.
Owner: OpenHands TypeScript client maintainers
Tracking: OpenHands/software-agent-sdk#4422

Server operations covered by an exposed browser URL (2)

  • GET /api/conversations/{}/workspace
  • GET /api/conversations/{}/workspace/{}

Reason: RemoteWorkspace.startWorkspaceSession exposes these authenticated URLs for browser iframe and file requests; they are not HttpClient method calls.
Owner: OpenHands TypeScript client maintainers

Update src/models/acp-providers.json to match the current ACP_PROVIDERS
in openhands-sdk main, including version bumps (claude-agent-acp 0.63.0→0.44.0,
codex-acp 1.1.7→1.1.2), model label changes (Claude Haiku 4.5→Claude Haiku),
and key ordering normalization. Update the acp-providers test expectation
to match the new codex-acp version.

Resolves the validate-acp-providers CI failure that was blocking
dependabot PRs #325 and #324.

Co-authored-by: openhands <openhands@all-hands.dev>
@neubig

neubig commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

Closing — the acp-providers.json on main is already correct. The drift was caused by a stale local SDK install. Rebasing #325 and #324 should resolve their validate-acp-providers failures.

@neubig neubig closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant