fix(acp): mirror Claude Opus 5 models from software-agent-sdk - #320
fix(acp): mirror Claude Opus 5 models from software-agent-sdk#320nicolasdmolina wants to merge 4 commits into
Conversation
Relabel opus[1m] to Claude Opus 5 (1M), add claude-opus-5 pin, and refresh the Sonnet alias label to Sonnet 5 so Agent Canvas matches the SDK registry.
|
@neubig The mirror now matches the final labels from merged OpenHands/software-agent-sdk#4326, and the ACP drift check plus focused client validation pass locally. Could you review and approve the fork workflow run when convenient? |
|
Friendly nudge — this is ready for review when you have a moment. |
|
@nicolasdmolina Sorry for the delay on this PR. I see CI is failing on this: https://github.com/OpenHands/typescript-client/actions/runs/31886064565/job/95015449401?pr=320 Do you know why? |
|
🚦 CI is currently failing on this PR's latest commit. Please fix the failing checks before OpenHands reviews it - this is re-checked automatically once you push a new commit. (A maintainer can also request This is an automated check - no AI was used to generate this comment. |
|
I fixed the CI drift failures in this PR on commit d0f772d (): updated src/models/acp-providers.json to @agentclientprotocol/claude-agent-acp@0.44.0 and @agentclientprotocol/codex-acp@1.1.2; updated src/tests/acp-providers.test.ts to expect codex-acp@1.1.2. I verified with local checks: npm test -- --runInBand src/tests/acp-providers.test.ts and scripts/check-acp-drift.py against the linked SDK commit both pass. Endpoint Audit is still failing with from the existing run. |
|
I fixed the CI drift failures in this PR on commit d0f772d ("fix(ci): align ACP providers with sdk drift target"): updated src/models/acp-providers.json to @agentclientprotocol/claude-agent-acp@0.44.0 and @agentclientprotocol/codex-acp@1.1.2, and updated src/tests/acp-providers.test.ts to expect codex-acp@1.1.2. I also verified locally that npx prettier --check and npm test -- --runInBand src/tests/acp-providers.test.ts pass, and scripts/check-acp-drift.py passes against the linked SDK commit. Endpoint Audit remains blocked by "Resource not accessible by integration". |
HUMAN:
This PR proposes to update typescript-client inline with the model registry merged previously in agent-sdk.
Summary
Mirrors the final Claude Code ACP model registry from OpenHands/software-agent-sdk#4326, which is merged.
opus[1m]→ Claude Opus (1M)sonnet→ Claude Sonnethaiku→ Claude Haikuclaude-opus-5pin → Claude Opus 5default_model: opus[1m]The short aliases are provider- and account-dependent, so version-neutral labels avoid going stale; the explicit
claude-opus-5entry remains available for users who want to pin Opus 5.Agent Canvas reads this registry via
@openhands/typescript-client, so this mirror keeps the model picker aligned with the merged SDK behavior.HUMAN:
npm ci,npx prettier --check src/models/acp-providers.json, andnpm test -- --runInBand src/__tests__/acp-providers.test.tson the updated branch and confirmed expected model entries and checks pass.Test plan
scripts/check-acp-drift.pymatches merged SDK #4326 (merge commitabeb884c)npm ci(includes the TypeScript build)npx prettier --check src/models/acp-providers.jsonnpm test -- --runInBand src/__tests__/acp-providers.test.ts