[18.0][FIX] web_responsive: prevent duplicate navigation on app menu click

[Pepo48]

Closes: #3653

[pedrobaeza]

This was done on purpose, as we don't want to block the navigation to the apps menu if there are missing required fields or to auto-save. Only when navigating to another menu, this will be performed.

[Pepo48]

@pedrobaeza thanks for the prompt reaction!

As for the clearUncommittedChanges check, I acknowledged it the issue description that it is a UX preference. I'm fine with dropping that part, although I would still argue that it makes the behaviour unintuitive.

But the ev.preventDefault() in AppMenuItem.onClick is a separate issue. Without it, clicking an app tile triggers navigation twice, once from the click handler, once from the browser following the link. Normally that's harmless, but when the current form has unsaved changes that can't be saved, the two paths conflict and the app freezes. Only a full page refresh recovers it.

The fix is just preventing the browser from following the link, which is standard for links handled by JavaScript. It's the same pattern Odoo uses for its own menu items.

[pedrobaeza]

OK, please keep only this second commit, rephrase the commit message accordingly, and remove [18.0] from it.

[pedrobaeza]

Thanks. Please add [FIX] to the commit message:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

[Pepo48]

@pedrobaeza done.

[tarteo]

Confirmed, I was able to reproduce the bug and this fixes the issue 👍

[pedrobaeza]

/ocabot merge patch

Please fw-port it to 19 if needed

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3654-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at c918d67. Thanks a lot for contributing to OCA. ❤️