Skip to content

[16.0][FIX] fs_attachment,fs_attachment_s3,fs_storage,fs_storage_backup: fix server_environment split migration and add uninstall hooks - #653

Open
yankinmax wants to merge 9 commits into
OCA:16.0from
camptocamp:fix-storage-split
Open

[16.0][FIX] fs_attachment,fs_attachment_s3,fs_storage,fs_storage_backup: fix server_environment split migration and add uninstall hooks#653
yankinmax wants to merge 9 commits into
OCA:16.0from
camptocamp:fix-storage-split

Conversation

@yankinmax

@yankinmax yankinmax commented Aug 19, 2026

Copy link
Copy Markdown

The PR was merged:

This PR fixes the broken migration scripts, which set ir_module_module::state directly via SQL instead of calling button_install, so the new *_environment modules never actually got installed on upgrade.
Scripts are moved to the upgrades/ folder (same version, no version bump) and fixed to call button_install.

Also adds uninstall_hook to each *_environment module, using restore_env_managed_columns from server_environment to restore the DB columns dropped by server.env.mixin when the module is uninstalled.

Depends on:

@oca-cla-bot

oca-cla-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:fs_storage Module fs_storage mod:fs_attachment Module fs_attachment series:16.0 mod:fs_attachment_s3 Module fs_attachment_s3 mod:fs_storage_environment Module fs_storage_environment mod:fs_storage_backup Module fs_storage_backup mod:fs_storage_backup_environment Module fs_storage_backup_environment mod:fs_attachment_s3_environment Module fs_attachment_s3_environment mod:fs_attachment_environment Module fs_attachment_environment labels Aug 19, 2026
@lmignon

lmignon commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

I haven't had any upgrade issues with the current implementation.... which doesn't mean the fix doesn't improve the robustness of the approach.

@yankinmax yankinmax changed the title [FIX] fs_attachment,fs_attachment_s3,fs_storage,fs_storage_backup: fix server_environment split migration and add uninstall hooks [16.0][FIX] fs_attachment,fs_attachment_s3,fs_storage,fs_storage_backup: fix server_environment split migration and add uninstall hooks Aug 20, 2026
@yankinmax

Copy link
Copy Markdown
Author

image_tag split is handled separately, because it doesn't introduce any server_env_fields override, so only need the upgrade script:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved mod:fs_attachment_environment Module fs_attachment_environment mod:fs_attachment_s3_environment Module fs_attachment_s3_environment mod:fs_attachment_s3 Module fs_attachment_s3 mod:fs_attachment Module fs_attachment mod:fs_storage_backup_environment Module fs_storage_backup_environment mod:fs_storage_backup Module fs_storage_backup mod:fs_storage_environment Module fs_storage_environment mod:fs_storage Module fs_storage series:16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants