Chore/small improvements

[Raghavan1988]

Note

Low Risk
Changes are mostly validation, typing, and DRY refactors; the Env.init **kwargs change is a minor signature fix with existing subclasses using named parameters.

Overview
This PR tightens configuration and API ergonomics with clearer validation and small refactors, plus clearer GSM8K test documentation.

Validation: _import_object in the agent auto-loader now rejects import paths without a dot with an explicit error. load_env_creator rejects malformed registry entry points unless they contain exactly one :.

API / behavior: The base Env.init signature is updated from *kwargs to **kwargs. Metric aggregation in default_aggregate_metrics is simplified to average any int/float (including bools) and skip other types. check_is_vlm uses a single getattr(..., None) check.

Refactor: Boolean SkyRL env vars (SKYRL_LD_LIBRARY_PATH_EXPORT, SKYRL_PYTHONPATH_EXPORT, SKYRL_DUMP_INFRA_LOG_TO_STDOUT) share a new _env_flag helper. GSM8K scoring tests gain comments explaining format vs correctness expectations.

^{Reviewed by Cursor Bugbot for commit 3426c47. Bugbot is set up for automated code reviews on this repo. Configure here.}

[gemini-code-assist]

Code Review

This pull request introduces several robustness improvements, bug fixes, and refactorings across the codebase, including validating import paths and entry points, fixing the signature of the init method in skyrl_gym/core.py from *kwargs to **kwargs, simplifying metric aggregation, and introducing a helper to parse boolean environment variables. The review feedback suggests hardening the new validation logic in auto.py and registration.py to handle edge cases where the input string starts or ends with the delimiter, and refactoring the _env_flag helper to avoid unnecessary string conversions of the default value.

[gemini-code-assist]

The validation only checks if . is in path. However, if path starts or ends with a dot (e.g., ".ClassName" or "module.path."), rsplit(".", 1) will produce empty strings for module_path or class_name. This can lead to unhandled ValueError (from import_module("")) or AttributeError (from getattr(..., "")).

We can make this more robust by also checking that neither split part is empty.

Suggested change

	if "." not in path:
	raise ValueError(
	f"Invalid import path '{path}'. Expected a dotted 'module.path.ClassName', e.g. 'skyrl_agent.agents.runner.AgentRunner'."
	)
	if "." not in path or not all(path.rsplit(".", 1)):
	raise ValueError(
	f"Invalid import path '{path}'. Expected a dotted 'module.path.ClassName', e.g. 'skyrl_agent.agents.runner.AgentRunner'."
	)

[gemini-code-assist]

The validation checks if there is exactly one : in name. However, if name starts or ends with : (e.g., ":MyEnv" or "my_pkg:"), name.split(":") will produce empty strings for mod_name or attr_name. This can lead to unhandled ValueError (from import_module("")) or AttributeError (from getattr(..., "")).

We can make this more robust by also checking that neither split part is empty.

Suggested change

	if name.count(":") != 1:
	raise error.Error(
	f"Malformed entry point '{name}'. Expected the form '(import path):(environment name)', e.g. 'my_pkg.envs:MyEnv'."
	)
	if name.count(":") != 1 or not all(name.split(":")):
	raise error.Error(
	f"Malformed entry point '{name}'. Expected the form '(import path):(environment name)', e.g. 'my_pkg.envs:MyEnv'."
	)

[gemini-code-assist]

Converting the boolean default to a string ("True" or "False") and then parsing it back via _TRUTHY is a bit indirect and less readable. It is cleaner and more idiomatic to check if the environment variable is present first, and if not, directly return the boolean default.

Suggested change

	return os.environ.get(name, str(default)).strip().lower() in _TRUTHY
	val = os.environ.get(name)
	if val is None:
	return default
	return val.strip().lower() in _TRUTHY

[greptile-apps]

Confidence Score: 4/5

The PR appears safe to merge after aligning the base environment initialization signature with the positional prompt contract used by its implementations.

Findings

1.  Base init contract mismatch ▶

_{Reviews (1) · Last reviewed commit: "feat(agent): validate dotted import path..."}

[greptile-apps]

Base init contract mismatch

The base Env.init method now accepts only keyword arguments, but concrete environments define init(self, prompt), callers pass prompt positionally, and the environment-authoring guide documents that positional form. This gives extension authors and static-analysis tools an inaccurate public contract; the base signature should declare the actual prompt parameter.

Suggested change

	def init(self, **kwargs) -> Tuple[ObsType, Dict[str, Any]]:
	def init(self, prompt: ObsType) -> Tuple[ObsType, Dict[str, Any]]: