Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces full-context profiling capabilities for GLM models through SkyRL's Tinker API, adding configuration profiles, server and client scripts, and comprehensive tests. It also implements a decorator to flush active torch profiler traces upon encountering a CUDA OutOfMemoryError. The review feedback suggests two important robustness improvements: safely accessing the profiler attribute using getattr in the OOM decorator to avoid masking the original error with an AttributeError, and adding a sleep delay in the client's model unloading loop when handling 408 status codes to prevent a tight busy-polling loop.
930706b to
bada2c2
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit bada2c2. Configure here.
c661283 to
4cd7535
Compare
Signed-off-by: Hersh Godse <hersh@trajectory.ai>
Signed-off-by: Hersh Godse <hersh@trajectory.ai>
Signed-off-by: Hersh Godse <hersh@trajectory.ai>
Signed-off-by: Hersh Godse <hersh@trajectory.ai>
885be0f to
80a3d95
Compare

inference_engine_initialization_aggregateandsampler_weight_sync. Missing vLLM substages and standalone activation stay absent; distributed attribution uses rank maximum, never rank sum.skyrl.tinker.qualification.run_lora_qualificationfor the shared [GLM 5.3 Tests] Check trainer/inference LoRA logprob agreement #2182 evidence sequence, and updates the two-trainer-node 256K recipe to TP4/CP2/PP2.Testing
Changed-file pre-commit and compileall passed. The local full Tinker collection reached 222 passed/22 skipped; its three setup errors were the CPU render fixture failing because optional local
vllmwas absent. Exact-head SkyRL-CPU and SkyRL-Train-CPU are green, including full pytest, engine benchmarks, code quality, gym, without-vLLM, with-vLLM, and Tinker jobs.Qualification status
Head:
80a3d95d34519bb2bb4ea7210138f6820d19423fBase:
a7637de1fd71e1696f08cae2b9ffcacb3297b9a0Profiling contract v10 is published and validator-clean:
ready.jsonSHA-25654a932acd3e4b4f38591247e5984b17881b976eb31fe704a442ec454cf086350;releases/v10/SHA256SUMSSHA-2567e4fe907399eeb917e23784afdb2d30e80fed4019b45b0be38ae422dd35df60c. It preserves accepted v9 contract 1.3.0, both schema versions 1.1.0, #2190 dependency metadata, public endpoint/helper identities, and unchanged qualification source bytes while repinning current main/head and camera-readiness evidence. The timer and 256K topology review threads are resolved; no review threads remain open.No image build or GPU/live campaign was run for this rebased head, by instruction. The automatic Anyscale GPU workflow failed on an empty token/invalid credentials before job submission or any product test; Vercel is an irrelevant deployment-authorization check for this Python-only PR.
Historical roughly 600-second warm-publication measurements remain old-stack context, not a current denominator. The final performance comparison is matched profiler-disabled baseline Arm A versus the selected independently numerics-qualified native candidate; profiler-enabled runs are attribution-only. Retired Arms B/D and #2195 are excluded.