Skip to content

[None][infra] Set --platform when retagging CI image - #18208

Merged
yuanjingx87 merged 1 commit into
NVIDIA:mainfrom
yuanjingx87:user/yuanjingx/retag_script_fix
Aug 26, 2026
Merged

[None][infra] Set --platform when retagging CI image#18208
yuanjingx87 merged 1 commit into
NVIDIA:mainfrom
yuanjingx87:user/yuanjingx/retag_script_fix

Conversation

@yuanjingx87

@yuanjingx87 yuanjingx87 commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Docker image pulls now specify an explicit platform.
  • SBSA images use linux/arm64.
  • Other images use linux/amd64.
  • Tagging, pushing, and file replacement behavior remain unchanged.
  • The change is limited to the CI image retagging workflow.
  • No public declarations changed.
  • No test files changed.

QA Engineer Review

No test changes.

Description

Currently if the image platform does not match local machine's architecture, the image is not able to be pulled. So set --platform when docker pull CI images

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d5c5dd87-9ce5-49b5-8daa-85a22427995b

📥 Commits

Reviewing files that changed from the base of the PR and between 6beb4b2 and d91e7c0.

📒 Files selected for processing (1)
  • scripts/rename_docker_images.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The Docker image rename script now specifies linux/arm64 for SBSA image pulls and linux/amd64 for other image pulls. Tagging, pushing, and file replacement remain unchanged.

Changes

Docker image renaming

Layer / File(s) Summary
Platform-aware Docker pulls
scripts/rename_docker_images.py
rename_images selects an explicit platform based on the destination key before pulling each image.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to d91e7

This localized change updates CI image retagging behavior to specify the platform, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the infrastructure change: setting --platform when retagging CI images.
Description check ✅ Passed The description explains the platform mismatch issue and the Docker pull change. Test coverage details are missing, but the description is otherwise relevant and complete enough for this small infrast…
Full details: Description check

Explanation

The description explains the platform mismatch issue and the Docker pull change. Test coverage details are missing, but the description is otherwise relevant and complete enough for this small infrastructure change.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@yuanjingx87

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "No CI needed"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #69475 [ skip ] triggered by Bot. Commit: d91e7c0 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #69475 [ skip ] completed with state SUCCESS. Commit: d91e7c0
Skipping testing for commit d91e7c0

Link to invocation

@yuanjingx87
yuanjingx87 merged commit ddd6206 into NVIDIA:main Aug 26, 2026
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants