Skip to content

Port OreSpawn 4.0.10 to Forge 1.19.4 - #261

Merged
SkyBlade1978 merged 12 commits into
MinecraftModDevelopmentMods:master-1.19from
SkyBlade1978:master-1.19
Aug 28, 2026
Merged

Port OreSpawn 4.0.10 to Forge 1.19.4#261
SkyBlade1978 merged 12 commits into
MinecraftModDevelopmentMods:master-1.19from
SkyBlade1978:master-1.19

Conversation

@SkyBlade1978

Copy link
Copy Markdown
Contributor

Ports the accepted OreSpawn 4.0.10 work to Forge 1.19.4.

  • preserves long Ore and Fluid editor values after reopening and saving
  • applies provider-declared natural terrain replacement before later authored features, addressing Residual vanilla Dirt survives total-conversion terrain replacement #255 for 1.19.4
  • evaluates rock height eligibility against actual world Y while keeping Stable Layers formation offsets separate, preventing vanilla Stone fallback near dimension floors
  • updates the ForgeGradle/Gradle CI/CD setup, reproducible release checks, Eclipse launches and documentation
  • releases as 4.0.10.119041 without changing API 1 or schemas 4/6/5

Validation completed with 121 tests across 31 suites, clean and cold build/Eclipse gates, exact packaged client and fresh/reload server runs, preferred-seed checks, artifact/documentation audits, clean runtime logs, and matched 4.0.9/4.0.10 performance with no regression. The exact candidate was also manually tested in Eclipse.

@SkyBlade1978

Copy link
Copy Markdown
Contributor Author

The CI failure was in ForgeGradle's cold-cache Mavenizer step, before OreSpawn compilation: Java 25 rejected eight redundant record accessors in Forge 1.19.4's decompiled sources.

This now uses a checksum-sealed MinecraftMavenizer 0.5.21 derivative scoped exactly to Forge 1.19.4-45.4.0, with strict eight-rule matching and an idempotent marker. CI also has a genuinely empty-cache bootstrap, pinned Java 25/17 toolchains (plus launcher-only Java 8), and a bounded cache-preserving retry for CodeQL's traced Mavenizer download timeouts.

Hosted cold bootstrap, build/test/artifact audit, wrapper validation and CodeQL all pass on 189a0cc. The cold log confirms Adoptium Java 25.0.3+9-LTS, all eight rule IDs and the expected manifest hash. Local qualification also passed 121 tests across 31 suites, fresh/reload surface runs, Eclipse isolation, and byte-for-byte comparison of all three public jars against 690623b.

Version remains 4.0.10.119041; no runtime code or public artifact content changed.

@SkyBlade1978
SkyBlade1978 merged commit 26e758f into MinecraftModDevelopmentMods:master-1.19 Aug 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant