fix: support two-component Minecraft versions - #6621
Merged
Big-Iron-Cheems merged 1 commit intoAug 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The version parsing logic was made overly restrictive by requiring exactly three numeric version components.
Minecraft release versions can contain either two or three components, such as
26.1,26.2, and26.2.1.The stricter parsing caused valid two-component versions to be rejected and
MeteorClient.VERSIONto fall back to0.0.0.This change restores the previous build-version handling in
MeteorClientwhile updatingVersionto correctly accept both two- and three-component versions.A missing third component is represented internally as
0for version comparisons, while the original version string is preserved.Related issues
Closes #6620.
How Has This Been Tested?
Tested by building and running Meteor with a two-component Minecraft version (26.2) and verifying that the Meteor version is correctly reported instead of
0.0.0.Checklist: