Skip to content

feat: added tracing for money-account-balance-service network requests#9451

Draft
ffmcgee725 wants to merge 1 commit into
mainfrom
jc/tracing-money-account-api-data-service
Draft

feat: added tracing for money-account-balance-service network requests#9451
ffmcgee725 wants to merge 1 commit into
mainfrom
jc/tracing-money-account-api-data-service

Conversation

@ffmcgee725

Copy link
Copy Markdown
Member

Add a trace constructor callback to MoneyAccountApiDataService that emits best-effort backdated spans for all HTTP calls (fetchPositions, fetchInterest, fetchHistory, fetchRateHistory). Tracing is isolated from fetch/retry logic so trace failures never impact queries. Mirrors the approach used in money-account-balance-service (PR #9434).

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

… requests

Add a `trace` constructor callback to MoneyAccountApiDataService that emits
best-effort backdated spans for all HTTP calls (fetchPositions, fetchInterest,
fetchHistory, fetchRateHistory). Tracing is isolated from fetch/retry logic
so trace failures never impact queries. Mirrors the approach used in
money-account-balance-service (PR #9434).

Co-authored-by: Cursor <cursoragent@cursor.com>
@ffmcgee725

Copy link
Copy Markdown
Member Author

@metamaskbot publish-preview

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/account-tree-controller@7.5.4-preview-14c30de
@metamask-previews/accounts-controller@39.0.4-preview-14c30de
@metamask-previews/address-book-controller@7.1.2-preview-14c30de
@metamask-previews/ai-controllers@0.8.0-preview-14c30de
@metamask-previews/analytics-controller@1.2.1-preview-14c30de
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-14c30de
@metamask-previews/announcement-controller@8.1.0-preview-14c30de
@metamask-previews/app-metadata-controller@2.0.1-preview-14c30de
@metamask-previews/approval-controller@9.0.2-preview-14c30de
@metamask-previews/assets-controller@10.1.0-preview-14c30de
@metamask-previews/assets-controllers@109.3.1-preview-14c30de
@metamask-previews/authenticated-user-storage@3.0.0-preview-14c30de
@metamask-previews/base-controller@9.1.0-preview-14c30de
@metamask-previews/base-data-service@0.1.3-preview-14c30de
@metamask-previews/bitcoin-regtest-up@1.0.0-preview-14c30de
@metamask-previews/bridge-controller@77.3.2-preview-14c30de
@metamask-previews/bridge-status-controller@74.1.1-preview-14c30de
@metamask-previews/build-utils@3.0.4-preview-14c30de
@metamask-previews/chain-agnostic-permission@1.7.0-preview-14c30de
@metamask-previews/chomp-api-service@3.1.0-preview-14c30de
@metamask-previews/claims-controller@0.5.3-preview-14c30de
@metamask-previews/client-controller@1.0.1-preview-14c30de
@metamask-previews/client-utils@1.0.0-preview-14c30de
@metamask-previews/compliance-controller@2.1.0-preview-14c30de
@metamask-previews/composable-controller@12.0.1-preview-14c30de
@metamask-previews/config-registry-controller@0.4.1-preview-14c30de
@metamask-previews/connectivity-controller@0.3.0-preview-14c30de
@metamask-previews/controller-utils@12.3.0-preview-14c30de
@metamask-previews/core-backend@6.5.0-preview-14c30de
@metamask-previews/delegation-controller@3.0.2-preview-14c30de
@metamask-previews/earn-controller@12.2.2-preview-14c30de
@metamask-previews/eip-5792-middleware@3.0.4-preview-14c30de
@metamask-previews/eip-7702-internal-rpc-middleware@0.1.1-preview-14c30de
@metamask-previews/eip1193-permission-middleware@2.0.1-preview-14c30de
@metamask-previews/ens-controller@19.1.5-preview-14c30de
@metamask-previews/eth-block-tracker@15.0.1-preview-14c30de
@metamask-previews/eth-json-rpc-middleware@23.1.3-preview-14c30de
@metamask-previews/eth-json-rpc-provider@6.0.1-preview-14c30de
@metamask-previews/foundryup@1.0.1-preview-14c30de
@metamask-previews/gas-fee-controller@26.2.4-preview-14c30de
@metamask-previews/gator-permissions-controller@4.2.2-preview-14c30de
@metamask-previews/geolocation-controller@0.1.3-preview-14c30de
@metamask-previews/java-tron-up@1.0.0-preview-14c30de
@metamask-previews/json-rpc-engine@10.5.0-preview-14c30de
@metamask-previews/json-rpc-middleware-stream@8.0.8-preview-14c30de
@metamask-previews/keyring-controller@27.1.0-preview-14c30de
@metamask-previews/local-node-utils@1.0.0-preview-14c30de
@metamask-previews/logging-controller@8.0.2-preview-14c30de
@metamask-previews/message-manager@14.1.2-preview-14c30de
@metamask-previews/messenger@2.0.0-preview-14c30de
@metamask-previews/messenger-cli@0.2.0-preview-14c30de
@metamask-previews/money-account-api-data-service@0.1.0-preview-14c30de
@metamask-previews/money-account-balance-service@2.1.2-preview-14c30de
@metamask-previews/money-account-controller@0.3.3-preview-14c30de
@metamask-previews/money-account-upgrade-controller@2.2.1-preview-14c30de
@metamask-previews/multichain-account-service@12.0.0-preview-14c30de
@metamask-previews/multichain-api-middleware@4.0.1-preview-14c30de
@metamask-previews/multichain-network-controller@3.2.1-preview-14c30de
@metamask-previews/multichain-transactions-controller@7.1.1-preview-14c30de
@metamask-previews/name-controller@9.1.2-preview-14c30de
@metamask-previews/network-connection-banner-controller@0.1.0-preview-14c30de
@metamask-previews/network-controller@34.0.0-preview-14c30de
@metamask-previews/network-enablement-controller@5.4.1-preview-14c30de
@metamask-previews/notification-services-controller@25.0.0-preview-14c30de
@metamask-previews/passkey-controller@2.0.1-preview-14c30de
@metamask-previews/permission-controller@13.1.1-preview-14c30de
@metamask-previews/permission-log-controller@5.1.0-preview-14c30de
@metamask-previews/perps-controller@9.2.1-preview-14c30de
@metamask-previews/phishing-controller@17.2.0-preview-14c30de
@metamask-previews/platform-api-docs@0.0.0-preview-14c30de
@metamask-previews/polling-controller@16.0.8-preview-14c30de
@metamask-previews/preferences-controller@23.1.0-preview-14c30de
@metamask-previews/profile-metrics-controller@4.0.1-preview-14c30de
@metamask-previews/profile-sync-controller@28.2.0-preview-14c30de
@metamask-previews/ramps-controller@15.1.0-preview-14c30de
@metamask-previews/rate-limit-controller@7.0.1-preview-14c30de
@metamask-previews/react-data-query@0.2.1-preview-14c30de
@metamask-previews/remote-feature-flag-controller@4.2.2-preview-14c30de
@metamask-previews/sample-controllers@5.0.3-preview-14c30de
@metamask-previews/seedless-onboarding-controller@10.0.3-preview-14c30de
@metamask-previews/selected-network-controller@26.1.5-preview-14c30de
@metamask-previews/shield-controller@5.1.2-preview-14c30de
@metamask-previews/signature-controller@39.2.7-preview-14c30de
@metamask-previews/smart-transactions-controller@25.0.0-preview-14c30de
@metamask-previews/snap-account-service@2.0.0-preview-14c30de
@metamask-previews/social-controllers@2.4.0-preview-14c30de
@metamask-previews/solana-test-validator-up@1.0.0-preview-14c30de
@metamask-previews/stellar-quickstart-up@0.0.0-preview-14c30de
@metamask-previews/storage-service@1.0.2-preview-14c30de
@metamask-previews/subscription-controller@6.2.0-preview-14c30de
@metamask-previews/transaction-controller@68.3.0-preview-14c30de
@metamask-previews/transaction-pay-controller@24.0.0-preview-14c30de
@metamask-previews/user-operation-controller@41.2.6-preview-14c30de
@metamask-previews/wallet@7.0.0-preview-14c30de
@metamask-previews/wallet-cli@0.0.0-preview-14c30de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant