Conversation
Added a checkbox to the bulk submission collection modal, checked by default, that gives every criterion a mark of 0 and sets the result's marking state to complete for any newly collected submission that contains no files. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
Coverage Report for CI Build 35003021117Warning No base build found for commit Coverage: 90.767%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When submissions are collected in bulk, groups that submitted nothing still produce a submission — it is just empty. Its result is created with a marking state of "In Progress" and no marks, so an instructor has to open each one and enter a 0 by hand before results can be released. In a large course that is a lot of clicking, and it is easy to miss a group.
This adds a "Assign grade of 0 to collected submissions that are empty." checkbox to the bulk submission collection modal, checked by default. When it is selected, every newly collected submission is checked for files; any submission with none gets a mark of 0 on every criterion and has its result's marking state set to "Completed".
Implementation:
collect_submissions_modal.jsx— the new checkbox, in the Collection options fieldset. It is shown for scanned exams as well, where an empty submission means no pages were assigned to that group.submission_table.jsx/SubmissionsController#collect_submissions— pass the choice through asassign_zero_to_empty.SubmissionsJob— after the submission rule is applied, an empty submission (Submission#is_empty, which the collector already sets from whether any submission files were populated) has its marks zeroed and its result completed. A failure there is reported through the job's existing warning-message channel rather than aborting the rest of the batch.Behaviour worth flagging for review: if both this option and Retain existing grading data are selected and a recollected submission turns out to be empty, the retained marks are overwritten with 0. This is deliberate and covered by a spec, but see the question below.
Scope: only the bulk collection modal. The API collection route and manual single-revision collection are unchanged — the option defaults to off there, so their behaviour is identical to before.
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)