Fix production JS builds compiling JSX in development mode - #8162
Merged
Merged
Conversation
david-yz-liu
approved these changes
Sep 9, 2026
david-yz-liu
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks @Naragod
Collaborator
Coverage Report for CI Build 34390073319Warning No base build found for commit Coverage: 90.514%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks #8150 onto
releaseso the branch builds a correct production bundle on its own.Why
v2.10.2 shipped without this fix.
@babel/preset-reactcompiled JSX in development mode, so the production bundle calledjsxDEV, which React's production build does not provide. The bundle died on its first component and pages lost their React tables.The workaround on the servers was an asset rebuild with
NODE_ENV=productionexported by hand. This commit makes the build set it itself.Scope
babel.config.jspreset-reactreceivesdevelopment: isDevelopmentEnv || isTestEnvwebpack.production.jsBABEL_ENVandNODE_ENVbefore webpack loadsChangelog.md[unreleased]Verification
ec4bf2bfrom master. Zero conflicts.babel.config.jsandwebpack.production.jsmd5-match master byte for byte.benandtiny, where the rebuilt bundle carries zerojsxDEVcalls.Tag
The
v2.10.2tag stays where it is. This commit lands onreleaseonly, so deployed boxes stop being a hand patch. #8150 keeps its v2.10.3 milestone.