Skip to content

Improve lens on timeline - #4740

Merged
ildyria merged 1 commit into
masterfrom
improve-lens
Sep 13, 2026
Merged

ildyria merged 1 commit into
masterfrom
improve-lens

Conversation

@ildyria

@ildyria ildyria commented Sep 13, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Improvements
    • Improved timeline lens label placement to reduce overlap and provide more consistent spacing.
    • The focused date and its immediate neighboring dates remain visible, with labels repositioned when necessary.
    • Updated lens styling so less prominent dates fade more smoothly based on their distance from focus.

@ildyria
ildyria requested a review from a team as a code owner September 13, 2026 19:19
@ildyria ildyria added the v8 label Sep 13, 2026
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

📝 Walkthrough

Walkthrough

Changes

Timeline lens behavior

Layer / File(s) Summary
Lens culling and prominence updates
resources/js/v8/components/gallery/timelineModule/TimelineDatesV3.vue
Candidates are sorted by spatial y. The focal item and immediate temporal neighbors remain visible. Directional sweeps use the last kept item for spacing. Opacity uses a fourth-power prominence falloff. An alternative falloff is documented in a comment.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🔵 Low · up to 3a311

Near either edge of the timeline lens, an immediately adjacent date label can be clipped after collision repositioning. Bound the repositioning before merging to keep that label visible.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit sorts the dates in line
The focal mark stays bright and fine
Neighbor labels gently part
Soft shadows fade with careful art
The lens now hops in order neat

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: cb2d6030-bdc6-43a8-b5b1-f730562e3f8d

📥 Commits

Reviewing files that changed from the base of the PR and between ba7c110 and 3a31118.

📒 Files selected for processing (1)
  • resources/js/v8/components/gallery/timelineModule/TimelineDatesV3.vue

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@ildyria
ildyria merged commit 49e44a4 into master Sep 13, 2026
22 checks passed
@ildyria
ildyria deleted the improve-lens branch September 13, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant