Skip to content

Fix display in non-timeline mode - #4738

Merged
ildyria merged 3 commits into
masterfrom
fix-no-timeline-view
Sep 12, 2026
Merged

ildyria merged 3 commits into
masterfrom
fix-no-timeline-view

Conversation

@ildyria

@ildyria ildyria commented Sep 12, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Album grid and list views now consistently hide timeline header rows when timeline headers are disabled.
    • Albums display as a single flat section when timeline grouping is unavailable or turned off.
    • Existing grouped sections remain visible when timeline headers are enabled.
    • Drag-and-select behavior now remains consistent between grouped timeline sections and a single flat section.
    • Public albums are excluded from drag-selection areas when shared albums are displayed separately, improving selection accuracy.

@ildyria
ildyria requested a review from a team as a code owner September 12, 2026 20:41
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 04e10fca-ad1d-4eb2-b77e-4d7c2a5721bd

📥 Commits

Reviewing files that changed from the base of the PR and between 7dc2793 and 80deea5.

📒 Files selected for processing (1)
  • resources/js/composables/album/dragAndSelect.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • resources/js/composables/album/dragAndSelect.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Virtualized album views now use a flat "all" boundary when headers are disabled or grouped boundary data is unavailable. Drag selection excludes public albums in directly shared-only mode. One list-view conditional was reformatted without changing behavior.

Changes

Album boundary selection

Layer / File(s) Summary
Header-aware view boundaries
resources/js/v8/components/gallery/albumModule/Virtualized/AlbumRootGridVirtual.vue, resources/js/v8/components/gallery/albumModule/Virtualized/AlbumRootListViewVirtual.vue, resources/js/v8/components/gallery/albumModule/Virtualized/AlbumThumbGridVirtual.vue, resources/js/v8/components/gallery/albumModule/Virtualized/AlbumListViewVirtual.vue
The views use grouped boundaries only when headers are enabled and boundary data is available. Otherwise, they use one flat "all" boundary.
Drag-selection filtering alignment
resources/js/composables/album/dragAndSelect.ts
getAlbumBoxesV3 excludes public albums in separate_shared_only mode before calculating selection geometry. It retains the existing NSFW filtering.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to 80dee

No merge-blocking risk is identified from the available review context.

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit hops through headers bright
Flat “all” bounds keep rows in sight
Shared tiles hide what should not show
Dragging follows the view below
Neat little boundaries guide the night

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 69fb3873-cc49-4a42-a7c6-687257b9f9a6

📥 Commits

Reviewing files that changed from the base of the PR and between 6eab5a3 and 076dce3.

📒 Files selected for processing (4)
  • resources/js/v8/components/gallery/albumModule/Virtualized/AlbumListViewVirtual.vue
  • resources/js/v8/components/gallery/albumModule/Virtualized/AlbumRootGridVirtual.vue
  • resources/js/v8/components/gallery/albumModule/Virtualized/AlbumRootListViewVirtual.vue
  • resources/js/v8/components/gallery/albumModule/Virtualized/AlbumThumbGridVirtual.vue

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4ef98749-7799-4d10-96be-b0056207ec93

📥 Commits

Reviewing files that changed from the base of the PR and between 076dce3 and 7dc2793.

📒 Files selected for processing (1)
  • resources/js/composables/album/dragAndSelect.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review.

Comment thread resources/js/composables/album/dragAndSelect.ts
@ildyria
ildyria merged commit 0b43a78 into master Sep 12, 2026
20 checks passed
@ildyria
ildyria deleted the fix-no-timeline-view branch September 12, 2026 21:32
@ildyria ildyria added the v8 label Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant