Skip to content

Fix folder multi processing - #4736

Merged
ildyria merged 1 commit into
masterfrom
multi-processing-folder
Sep 12, 2026
Merged

ildyria merged 1 commit into
masterfrom
multi-processing-folder

Conversation

@ildyria

@ildyria ildyria commented Sep 12, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved upload scheduling to fill available processing slots without starting duplicate uploads.
    • Queued files now begin uploading while other uploads are still in progress.
    • Uploads resume using the configured concurrent processing limit rather than a fixed single-upload limit.

@ildyria
ildyria requested a review from a team as a code owner September 12, 2026 20:27
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7cfd0b90-4763-45e9-812b-ea5707c38ae9

📥 Commits

Reviewing files that changed from the base of the PR and between 6eab5a3 and 9467dbe.

📒 Files selected for processing (2)
  • resources/js/v7/components/modals/UploadPanel.vue
  • resources/js/v8/components/modals/UploadPanel.vue

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Upload scheduling in both v7 and v8 now fills available processing slots based on active uploads. Completed uploads continue with the configured limit. Queue watchers start waiting uploads while other uploads remain active.

Changes

Upload concurrency scheduling

Layer / File(s) Summary
Calculate available upload slots
resources/js/v7/components/modals/UploadPanel.vue, resources/js/v8/components/modals/UploadPanel.vue
uploadNext calculates free slots from the configured limit and active uploads, then starts only the available waiting files.
Continue and auto-start queued uploads
resources/js/v7/components/modals/UploadPanel.vue, resources/js/v8/components/modals/UploadPanel.vue
Completed uploads pass the configured limit to uploadNext. Queue watchers start waiting files while uploads are active.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 9467d

The upload scheduling changes preserve the configured concurrency limit while allowing queued uploads to continue promptly. No merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit fills each upload slot,
The queue moves files in steady hops,
Active uploads keep their place,
Completed work makes room with grace,
The processing limit guides the pace.

Comment @coderabbitai help to get the list of available commands.

@ildyria
ildyria merged commit 3c60a54 into master Sep 12, 2026
21 of 22 checks passed
@ildyria
ildyria deleted the multi-processing-folder branch September 12, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant