Skip to content

Improve Ux - #4730

Open
ildyria wants to merge 1 commit into
masterfrom
profile-experience
Open

Improve Ux#4730
ildyria wants to merge 1 commit into
masterfrom
profile-experience

Conversation

@ildyria

@ildyria ildyria commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Profile users can now open and close a dedicated password-change section from a link.
    • Password guidance and confirmation fields appear when editing is enabled.
    • Closing the section clears entered password values, and successful updates automatically close it.
  • Localization

    • Added profile login labels for changing and canceling password changes across supported languages.

@ildyria
ildyria requested a review from a team as a code owner September 10, 2026 19:16
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7e57e5b9-1951-45d3-a23c-664bba8f247d

📥 Commits

Reviewing files that changed from the base of the PR and between b652ec2 and 44261b3.

📒 Files selected for processing (24)
  • lang/ar/profile.php
  • lang/bg/profile.php
  • lang/cz/profile.php
  • lang/de/profile.php
  • lang/el/profile.php
  • lang/en/profile.php
  • lang/es/profile.php
  • lang/fa/profile.php
  • lang/fr/profile.php
  • lang/hu/profile.php
  • lang/it/profile.php
  • lang/ja/profile.php
  • lang/nl/profile.php
  • lang/no/profile.php
  • lang/pl/profile.php
  • lang/pt/profile.php
  • lang/ru/profile.php
  • lang/sk/profile.php
  • lang/sv/profile.php
  • lang/tr/profile.php
  • lang/vi/profile.php
  • lang/zh_CN/profile.php
  • lang/zh_TW/profile.php
  • resources/js/v8/components/forms/profile/SetLogin.vue

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The profile form now hides password-editing fields until the user opens them. Closing the section clears password values, and successful updates close it. Profile language files add matching password-change labels.

Changes

Profile password change

Layer / File(s) Summary
Password change translation keys
lang/*/profile.php
Adds change_password and cancel_password_change entries to the profile login translations.
Password change form toggle
resources/js/v8/components/forms/profile/SetLogin.vue
Adds conditional password fields, toggle state, input clearing on close, and automatic closing after successful updates.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 44261

The profile now reveals password-editing controls only when requested, clears values when closed, and closes the section after updates, with matching locale labels. The supplied coverage shows the supported password-change paths remain intact.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit clicks the password door
Hidden fields appear, then hide once more
Fresh labels hop through every tongue
Old secret values are cleared when sprung
A saved change makes the section rest

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant