feat(match2): reduce number of bans generated in deadlock copypaste - #8027
Open
Corsaka wants to merge 6 commits into
Open
feat(match2): reduce number of bans generated in deadlock copypaste#8027Corsaka wants to merge 6 commits into
Corsaka wants to merge 6 commits into
Conversation
By default, deadlock drafting only has 2 bans (and rarely, 3). 6 is excessive by default.
hjpalpha
approved these changes
Aug 31, 2026
steve020607
approved these changes
Aug 31, 2026
ElectricalBoy
changed the title
ElectricalBoy
left a comment
ElectricalBoy
left a comment
Collaborator
There was a problem hiding this comment.
By default, deadlock drafting only has 2 bans (and rarely, 3)
if there are valid cases that need 3 bans, then why not make it configurable with user input?
Author
|
i somehow pinged myself in my own commit message. note to self to bite the bullet and clone the git repo in future Implemented suggested changes with a lightly hacky solution, tested at my sandbox. Form:BracketCopyPaste will need to be updated if merged, since the parameter is changing from a boolean to an integer. |
hjpalpha
requested changes
Sep 1, 2026
hjpalpha
left a comment
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
" --> '
don't define globals!
through implementation of hjpalpha's suggested changes, this increasingly complicated minor change is finally in a good state
hjpalpha
approved these changes
Sep 10, 2026
i've never seen this in lua before so i'm just gonna hope it works this way
hjpalpha
reviewed
Sep 10, 2026
|
|
||
| ---@param mapIndex integer | ||
| ---@param bans boolean | ||
| ---@param bans number? |
Collaborator
There was a problem hiding this comment.
since we use it for the range it has to be an integer
Suggested change
| ---@param bans number? | |
| ---@param bans integer |
| function WikiCopyPaste.getMatchCode(bestof, mode, index, opponents, args) | ||
| local showScore = Logic.nilOr(Logic.readBoolOrNil, bestof == 0) | ||
| local bans = Logic.readBool(args.bans) | ||
| local bans = tonumber(args.bans) |
Collaborator
There was a problem hiding this comment.
Suggested change
| local bans = tonumber(args.bans) | |
| local bans = tonumber(args.bans) or 0 |
use this instead so the linter shuts up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
By default, deadlock drafting only has 2 bans (and rarely, 3). 6 is excessive and I've changed that here.
How did you test this change?
I implemented the custom code at .../wiki/dev/corsaka. I ran this edited BracketCopyPaste at my sandbox via
{{GetBracketCopyPaste|dev=corsaka|...}}. The results correctly show only two bans.