Skip to content

feat: add modules for stats display on sc2 player and team pages - #7363

Open
hjpalpha wants to merge 1 commit into
mainfrom
stats-oin-sc2-player-and-team-pages
Open

feat: add modules for stats display on sc2 player and team pages#7363
hjpalpha wants to merge 1 commit into
mainfrom
stats-oin-sc2-player-and-team-pages

Conversation

@hjpalpha

@hjpalpha hjpalpha commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

stacked on #8067

Summary

as title says

How did you test this change?

dev

@hjpalpha
hjpalpha marked this pull request as ready for review April 10, 2026 12:50
@hjpalpha
hjpalpha requested review from a team as code owners April 10, 2026 12:50
Comment thread lua/wikis/starcraft2/Widget/PlayerPageStatistics.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/TeamPageStatistics.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/EarningsStatsChart.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/PlayerPageStatistics.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/MedalsTable.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/TeamPageStatistics.lua Outdated
@ElectricalBoy ElectricalBoy added the g: starcraft Starcraft label Apr 11, 2026
@hjpalpha
hjpalpha requested a review from ElectricalBoy April 11, 2026 05:46
Comment thread lua/wikis/starcraft2/Widget/PlayerPageStatistics.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/PlayerPageStatistics.lua Outdated
@hjpalpha
hjpalpha requested a review from ElectricalBoy April 11, 2026 06:50
Comment thread lua/wikis/commons/Widget/EarningsStatsChart.lua
Comment thread lua/wikis/commons/Widget/MedalsTable.lua
@hjpalpha
hjpalpha requested a review from mbergen April 11, 2026 15:13
Comment thread lua/wikis/commons/Widget/MedalsTable.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/PlayerPageStatistics.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/PlayerPageStatistics.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/PlayerPageStatistics.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/PlayerPageStatistics.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/TeamPageStatistics.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/TeamPageStatistics.lua Outdated
Comment thread lua/wikis/commons/Widget/MedalsTable.lua
Comment thread lua/wikis/commons/Widget/EarningsStatsChart.lua Outdated
@hjpalpha
hjpalpha requested a review from ElectricalBoy April 13, 2026 09:27
Comment thread lua/wikis/commons/Infobox/Extension/PlacementStats.lua
Comment thread lua/wikis/commons/Infobox/Extension/PlacementStats.lua Outdated
Comment thread lua/wikis/commons/Widget/MedalsTable.lua Outdated
Comment thread lua/wikis/commons/SeriesMedalStats.lua Outdated
Comment thread lua/wikis/commons/SeriesMedalStats.lua
Comment thread lua/wikis/starcraft2/Widget/PlayerPageStatistics.lua Outdated
Comment thread lua/wikis/starcraft2/Widget/TeamPageStatistics.lua Outdated
@hjpalpha
hjpalpha changed the base branch from main to medals-table-widget September 8, 2026 18:24
@hjpalpha
hjpalpha force-pushed the stats-oin-sc2-player-and-team-pages branch from 82aa051 to 8ae13ad Compare September 8, 2026 18:43
Base automatically changed from medals-table-widget to main September 9, 2026 08:28
as per review

Apply suggestions from code review

Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>

Rename EarningsStatsChart.lua to EarningsStatsChart.lua

Rename MedalsTable.lua to MedalsTable.lua

as per review

unused import

chore: update visual snapshots

chore: update visual snapshots

use v3 html

port to v3 widget

nil check

chore: update visual snapshots

chore: update visual snapshots

use Opponent.readOpponentArgs

some anno fixes

chore: update visual snapshots

use placement badge instead of medal icon

chore: update visual snapshots

as per review

kick unused import

Update SeriesMedalStats.lua

chore: update visual snapshots

chore: update visual snapshots
@Rathoz
Rathoz force-pushed the stats-oin-sc2-player-and-team-pages branch from 8ae13ad to 41942cc Compare September 9, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

g: starcraft Starcraft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants