fix(hero): make banner full-bleed on wide screens - #486
Merged
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Contributor
|
Member
|
Look at my 4k display: 
If is hd display it's ok: 
Do we have a solution for this? |
Member
|
Maybe we can use the same image as the background with a blur effect: .ud-hero {
position: relative;
overflow: hidden;
&::before {
content: "";
position: absolute;
inset: -40px;
background-image: var(--hero-image);
background-size: cover;
background-position: center;
filter: blur(32px);
transform: scale(1.08);
opacity: 0.7;
}
}And limit the main image width: .ud-hero-image {
position: absolute;
inset: 0 0 0 auto;
width: min(1920px, 100%);
}This could fill the extra space on very wide screens using colors from the same image, without stretching the main image too much. |
…backdrop Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Contributor
Author
|
I made the adjustment, but the preview didn't update. I took some screenshots: 
|
Member
|
The preview was updated. Sometimes the deploy of a new preview delay a bit. |
Contributor
|
🚀 Starting production deploy of site header and footer fragments... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.