fix(lint): review and enable rules from @nextcloud/eslint-config v9 migration - #8067
Draft
masterlouis wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #7876. Reviews and progressively enables the ESLint rules
newly introduced by @nextcloud/eslint-config v9, as tracked in
libresign/disabled-during-migrationineslint.config.mjs.Work in progress — see commits for individual rules enabled so far.
Done so far
vue/no-unused-componentsneedsfiles: ['**/*.vue']since thevueplugin is only registered for.vuefiles in v9.import/orderandimport/no-unresolvedreferencedeslint-plugin-import, which was removed entirely in v9 (replacedby
perfectionist/sort-importsandimport-extensions/*).eslint-disablecomments referencing rules that nolonger exist or no longer apply in their file's context.
libresign/disabled-during-migrationblock listing all rulespending review, as the source of truth for this task.
Still to do