Desktop: list every trained pipe, not just the first - #1885
Merged
Conversation
Training can emit both detector.pipe and tracker.pipe; getPipelineList picked whichever readdir returned first and dropped the rest. Emit one entry per pipe, named like web does.
BryonLewis
approved these changes
Sep 3, 2026
BryonLewis
left a comment
Collaborator
There was a problem hiding this comment.
This looks proper, before we were just grabbing the detectors because I believe we didn't have trackers initially. This looks like it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
category_models/detector.pipeandtracker.pipe.getPipelineListusedfindto take the first.pipeinreaddirorder and dropped the rest, so the tracker was never runnable from desktop (which one won was FS-dependent: alphabetical on NTFS, hash order on ext4).trainedentry per.pipe, sorted for deterministic order, suffixeddetector/trackerto match web (crud_rpc.py:_load_dynamic_pipelines).detectorsuffix, same as web.detectorAndTrackerTrainingJobfixture with both pipes + test asserting two entries; existing trained test now pins the name. 118 passed, eslint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Nzq6XQBXKUb1NRdaVpPYQZ