Skip to content

Desktop: list every trained pipe, not just the first - #1885

Merged
BryonLewis merged 1 commit into
mainfrom
dev/trained-tracker-pipeline
Sep 3, 2026
Merged

Desktop: list every trained pipe, not just the first#1885
BryonLewis merged 1 commit into
mainfrom
dev/trained-tracker-pipeline

Conversation

@mattdawkins

Copy link
Copy Markdown
Member
  • VIAME training can emit both category_models/detector.pipe and tracker.pipe. getPipelineList used find to take the first .pipe in readdir order and dropped the rest, so the tracker was never runnable from desktop (which one won was FS-dependent: alphabetical on NTFS, hash order on ext4).
  • Now emits one trained entry per .pipe, sorted for deterministic order, suffixed detector / tracker to match web (crud_rpc.py:_load_dynamic_pipelines).
  • Single-pipe models still produce exactly one entry; their display name gains the detector suffix, same as web.
  • Deleting either entry still removes the whole model folder, unchanged and identical to web.
  • Spec: new detectorAndTrackerTrainingJob fixture with both pipes + test asserting two entries; existing trained test now pins the name. 118 passed, eslint clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Nzq6XQBXKUb1NRdaVpPYQZ

Training can emit both detector.pipe and tracker.pipe; getPipelineList
picked whichever readdir returned first and dropped the rest. Emit one
entry per pipe, named like web does.

@BryonLewis BryonLewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks proper, before we were just grabbing the detectors because I believe we didn't have trackers initially. This looks like it

@BryonLewis
BryonLewis merged commit 6bd5a00 into main Sep 3, 2026
3 checks passed
@BryonLewis
BryonLewis deleted the dev/trained-tracker-pipeline branch September 3, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants