Conversation
- Fail AllocateInputBuffers/EncodeInternal with a logged error when GraphicsContext is unset or not an OpenGL render window, instead of dereferencing null. - Align 4:2:0 encode dimensions down to even values; NVENC rejects odd luma sizes, which appear with fractional devicePixelRatio scaling. - Check encode dimensions against codec min/max caps so failure is actionable instead of a bare NV_ENC_ERR_INVALID_PARAM. - CheckAvailability: probe with an offscreen GL context and fix the SetWidth/SetHeight typo.
jspanchu
commented
Jul 3, 2026
| << encodeWidth << "x" << encodeHeight << " exceed the NVENC limit of " | ||
| << maxWidth << "x" << maxHeight | ||
| << " for the chosen codec. Reduce the frame size or switch to a codec with " | ||
| "higher limits (ex: HEVC)."); |
Member
Author
There was a problem hiding this comment.
we do not support hevc yet. but if folks are on hi-dpi 4k screens and window.devicePixelRatio > 1.0, then they will run into this.
Member
Author
|
Ran nvenc+opengl tests locally on windows + linux successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.