Retain project role when users re-added to project via LDAP - #3880
Merged
Conversation
CDash currently adds all LDAP-controlled project members at the most basic user level, with no ability to have admins for LDAP-managed projects. Users who are added as project admins by direct database manipulation have their admin status revoked if the LDAP server fails temporarily. This PR adds an "audit log" of sorts, storing the history of project membership. The log is used to restore users at their previous access level when regaining access to an LDAP-managed project.
josephsnyder
approved these changes
Jul 29, 2026
williamjallen
added a commit
to williamjallen/CDash
that referenced
this pull request
Aug 4, 2026
It's currently impossible to change user roles in LDAP-managed projects via the UI. In light of Kitware#3880, there is no longer a reason for this to be prohibited. This PR changes the behavior to allow project and global administrators to change user roles for LDAP-managed projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDash currently adds all LDAP-controlled project members at the most basic user level, with no ability to have admins for LDAP-managed projects. Users who are added as project admins by direct database manipulation have their admin status revoked if the LDAP server fails temporarily. This PR adds an "audit log" of sorts, storing the history of project membership. The log is used to restore users at their previous access level when regaining access to an LDAP-managed project.