Correction in 02_Validation_layers.adoc#381
Open
melvi-l wants to merge 2 commits into
Open
Conversation
Author
|
Also, I find it quite confusing to have extensions covered in both https://docs.vulkan.org/tutorial/latest/03_Drawing_a_triangle/00_Setup/01_Instance.html#_creating_an_instance and https://docs.vulkan.org/tutorial/latest/03_Drawing_a_triangle/00_Setup/02_Validation_layers.html#_using_extensions |
SaschaWillems
requested changes
May 30, 2026
| supported instance extensions by using the | ||
| `vk::raii::Context::enumerateInstanceLayerProperties` function and check that all | ||
| `vk::raii::Context::enumerateInstanceExtensionProperties` function and check that all | ||
| required layers are listed in that list. This check is also performed directly in the |
Collaborator
There was a problem hiding this comment.
Wording also needs to be changed from "...required layers" to "...required extensions".
Author
There was a problem hiding this comment.
sorry for the delay, thank you for the feedback.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
Thank you very much for this amazing tutorial.
I think I find a typo.
Have a wonderful day/evening !